Fix handling of not started runner because of failing finecode.sh . Log RunnerFailedToStart message instead of exception object

Author: Aksem

finecode/workspace_manager/cli_app/run.py

@@ -38,10 +38,10 @@ async def run_actions(
     try:
         try:
             await runner_manager.update_runners(ws_context)
-        except runner_manager.RunnerFailedToStart:
+        except runner_manager.RunnerFailedToStart as exception:
             raise RunFailed(
                 f"One or more projects are misconfigured, runners for them didn't"
-                " start. Check logs for details."
+                f" start: {exception.message}. Check logs for details."
             )
 
         actions_by_projects: dict[pathlib.Path, list[str]] = {}

finecode/workspace_manager/runner/manager.py

@@ -24,7 +24,9 @@
 )
 
 
-class RunnerFailedToStart(Exception): ...
+class RunnerFailedToStart(Exception):
+    def __init__(self, message: str) -> None:
+        self.message = message
 
 
 async def notify_project_changed(project: domain.Project) -> None:
@@ -181,6 +183,9 @@ async def update_runners(ws_context: context.WorkspaceContext) -> None:
     #
     # during initialization of new runners it also reads their configurations and
     # actions
+    #
+    # this function should handle all possible statuses of projects and they either
+    # start of fail to start, only projects without finecode are ignored
     extension_runners = list(ws_context.ws_projects_extension_runners.values())
     new_dirs, deleted_dirs = dirs_utils.find_changed_dirs(
         [*ws_context.ws_projects.keys()],
@@ -198,20 +203,20 @@ async def update_runners(ws_context: context.WorkspaceContext) -> None:
         await stop_extension_runner(runner_to_delete)
         extension_runners.remove(runner_to_delete)
 
-    new_runners_coros = [
-        start_extension_runner(runner_dir=new_dir, ws_context=ws_context)
-        for new_dir in new_dirs
-        if ws_context.ws_projects[new_dir].status == domain.ProjectStatus.READY
-    ]
     new_runners_tasks: list[asyncio.Task] = []
     try:
         async with asyncio.TaskGroup() as tg:
-            for coro in new_runners_coros:
-                runner_task = tg.create_task(coro)
-                new_runners_tasks.append(runner_task)
+            for new_dir in new_dirs:
+                project = ws_context.ws_projects[new_dir]
+                project_status = project.status
+                if project_status == domain.ProjectStatus.READY:
+                    runner_task = tg.create_task(start_extension_runner(runner_dir=new_dir, ws_context=ws_context))
+                    new_runners_tasks.append(runner_task)
+                elif project_status != domain.ProjectStatus.NO_FINECODE:
+                    raise RunnerFailedToStart(f"Runner for project '{project.name}' failed to start, status: {project_status.name}")
     except ExceptionGroup as eg:
         for exception in eg.exceptions:
-            if isinstance(exception, runner_client.BaseRunnerRequestException):
+            if isinstance(exception, runner_client.BaseRunnerRequestException) or isinstance(exception, RunnerFailedToStart):
                 logger.error(exception.message)
             else:
                 logger.exception(exception)

finecode/workspace_manager/services.py

@@ -48,7 +48,7 @@ def on_shutdown(ws_context: context.WorkspaceContext):
         if ws_context.ws_projects[runner.working_dir_path].status
         == domain.ProjectStatus.RUNNING
     ]
-    logger.info(f"Stop all {len(running_runners)} running extension runners")
+    logger.trace(f"Stop all {len(running_runners)} running extension runners")
 
     for runner in running_runners:
         runner_manager.stop_extension_runner_sync(runner=runner)