WIP address no-unnecessary-condition

Author: mstange

src/actions/profile-view.ts

@@ -1080,7 +1080,6 @@ export function isolateProcess(
       for (const localTrack of localTracks) {
         if (
           localTrack.type === 'thread' &&
-          localTrack.threadIndex !== undefined &&
           oldSelectedThreadIndexes.has(localTrack.threadIndex)
         ) {
           newSelectedThreadIndexes.add(localTrack.threadIndex);

src/actions/receive-profile.ts

@@ -1096,7 +1096,7 @@ async function _extractJsonFromResponse(
       message = 'The network request to load the profile was aborted.';
     } else if (fileType === 'application/json') {
       message = 'The profile’s JSON could not be decoded.';
-    } else if (fileType === null && arrayBuffer !== null) {
+    } else if (arrayBuffer !== null) {
       // If the content type is not specified, use a raw array buffer
       // to fallback to other supported profile formats.
       return arrayBuffer;
@@ -1163,10 +1163,6 @@ export function retrieveProfileOrZipFromUrl(
             serializedProfile,
             profileUrl
           );
-          if (profile === undefined) {
-            throw new Error('Unable to parse the profile.');
-          }
-
           await dispatch(loadProfile(profile, {}, initialLoad));
           break;
         }

src/app-logic/url-handling.ts

@@ -892,7 +892,7 @@ const _upgraders: {
     // will not be preserved.
     const transforms = parseTransforms(query.transforms);
 
-    if (!transforms || transforms.length === 0) {
+    if (transforms.length === 0) {
       // We don't have any transforms to upgrade.
       return;
     }

src/profile-logic/profile-data.ts

@@ -2773,15 +2773,11 @@ export function getThreadProcessDetails(
 ): string {
   let label = `${friendlyThreadName}\n`;
   label += `Thread: "${thread.name}"`;
-  if (thread.tid !== undefined) {
-    label += ` (${thread.tid})`;
-  }
+  label += ` (${thread.tid})`;
 
   if (thread.processType) {
     label += `\nProcess: "${thread.processType}"`;
-    if (thread.pid !== undefined) {
-      label += ` (${thread.pid})`;
-    }
+    label += ` (${thread.pid})`;
   }
 
   if (thread.isPrivateBrowsing) {

src/profile-logic/tracks.ts

@@ -144,10 +144,7 @@ function _getDefaultLocalTrackOrder(
     if (tracks[a].type === 'thread' && tracks[b].type === 'thread' && profile) {
       const idxA = tracks[a].threadIndex;
       const idxB = tracks[b].threadIndex;
-      if (idxA === undefined || idxB === undefined) {
-        return -1;
-      }
-      if (profile && profile.meta.keepProfileThreadOrder) {
+      if (profile.meta.keepProfileThreadOrder) {
         return idxA - idxB;
       }
       const nameA = profile.threads[idxA].name;

src/selectors/profile.ts

@@ -274,7 +274,7 @@ export const getMarkerSchemaByName: Selector<MarkerSchemaByName> =
 
 type CounterSelectors = ReturnType<typeof _createCounterSelectors>;
 
-const _counterSelectors: { [key: number]: CounterSelectors } = {};
+const _counterSelectors: Partial<Record<number, CounterSelectors>> = {};
 export const getCounterSelectors = (index: CounterIndex): CounterSelectors => {
   let selectors = _counterSelectors[index];
   if (!selectors) {
@@ -629,11 +629,6 @@ export const getHiddenTrackCount: Selector<HiddenTrackCount> = createSelector(
       if (globalTrackIndex === -1) {
         throw new Error('Unable to find a global track from the given pid.');
       }
-      if (!hiddenLocalTracks) {
-        throw new Error(
-          'Unable to find the hidden local tracks from the given pid'
-        );
-      }
 
       if (hiddenGlobalTracks.has(globalTrackIndex)) {
         // The entire process group is hidden, count all of the tracks.
@@ -805,10 +800,6 @@ export const getProfileFilterSortedPageData: Selector<SortedTabPageData> =
         }
         for (const threadIndex of threadIndexes.values()) {
           const threadScore = threadActivityScores[threadIndex];
-          if (!threadScore) {
-            throw new Error('Failed to find the thread score!');
-          }
-
           tabScore += threadScore.boostedSampleScore;
         }
         pageDataWithScore.push({

src/selectors/zipped-profiles.tsx

@@ -74,10 +74,11 @@ export const getZipFileMaxDepth: Selector<number> = createSelector(
  * render a file picker to load profiles from the zip file.
  */
 export const getZipFileTreeOrNull: Selector<ZipFiles.ZipFileTree | null> =
-  createSelector(getZipFileTable, getProfileUrl, (zipFileTable, zipFileUrl) =>
-    zipFileTable === null
-      ? null
-      : new ZipFiles.ZipFileTree(zipFileTable, zipFileUrl)
+  createSelector(
+    getZipFileTable,
+    getProfileUrl,
+    (zipFileTable, zipFileUrl) =>
+      new ZipFiles.ZipFileTree(zipFileTable, zipFileUrl)
   );
 
 /**

src/symbolicator-cli/index.ts

@@ -94,9 +94,6 @@ export async function run(options: CliOptions) {
 
   // Load the profile.
   const profile = await unserializeProfileOfArbitraryFormat(byteBufferCopy);
-  if (profile === undefined) {
-    throw new Error('Unable to parse the profile.');
-  }
 
   const symbolStoreDB = new InMemorySymbolDB();
 

src/types/state.ts

@@ -67,7 +67,7 @@ export type TableViewOptions = {
   readonly fixedColumnWidths: Array<CssPixels> | null;
 };
 
-export type TableViewOptionsPerTab = { [K in TabSlug]: TableViewOptions };
+export type TableViewOptionsPerTab = Partial<Record<TabSlug, TableViewOptions>>;
 
 export type RightClickedCallNode = {
   readonly threadsKey: ThreadsKey;