Skip to content

Commit 0b9cdee

Browse files
Refactor BannerMessages to use widgets instead of data classes (#8987)
1 parent 52d26f4 commit 0b9cdee

10 files changed

Lines changed: 270 additions & 316 deletions

File tree

packages/devtools_app/lib/src/extensions/embedded/_view_web.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -314,12 +314,13 @@ class _ExtensionIFrameController extends DisposableController
314314
'${showBannerMessageEvent.messageId}',
315315
),
316316
screenId: '${showBannerMessageEvent.extensionName}_ext',
317-
textSpans: [
318-
TextSpan(
319-
text: showBannerMessageEvent.message,
320-
style: TextStyle(fontSize: defaultFontSize),
321-
),
322-
],
317+
buildTextSpans:
318+
(_) => [
319+
TextSpan(
320+
text: showBannerMessageEvent.message,
321+
style: TextStyle(fontSize: defaultFontSize),
322+
),
323+
],
323324
);
324325
bannerMessages.addMessage(
325326
bannerMessage,

packages/devtools_app/lib/src/screens/debugger/debugger_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class _DebuggerScreenBodyWrapperState extends State<_DebuggerScreenBodyWrapper>
125125
@override
126126
void didChangeDependencies() {
127127
super.didChangeDependencies();
128-
pushDebuggerIdeRecommendationMessage(context, DebuggerScreen.id);
128+
pushDebuggerIdeRecommendationMessage(DebuggerScreen.id);
129129
}
130130

131131
@override

packages/devtools_app/lib/src/screens/inspector_v2/inspector_screen_body.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
228228
// Mark the welcome message as shown.
229229
await storage.setValue(_welcomeShownStorageId, 'true');
230230
if (context.mounted) {
231-
pushWelcomeToNewInspectorMessage(context, InspectorScreen.id);
231+
pushWelcomeToNewInspectorMessage(InspectorScreen.id);
232232
}
233233
}
234234
}

packages/devtools_app/lib/src/screens/memory/framework/screen_body.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ class _ConnectedMemoryBodyState extends State<ConnectedMemoryBody>
3737
void didChangeDependencies() {
3838
super.didChangeDependencies();
3939
if (!offlineDataController.showingOfflineData.value) {
40-
maybePushDebugModeMemoryMessage(context, ScreenMetaData.memory.id);
41-
maybePushHttpLoggingMessage(context, ScreenMetaData.memory.id);
40+
maybePushDebugModeMemoryMessage(ScreenMetaData.memory.id);
41+
maybePushHttpLoggingMessage(ScreenMetaData.memory.id);
4242

4343
addAutoDisposeListener(http_service.httpLoggingState, () {
44-
maybePushHttpLoggingMessage(context, ScreenMetaData.memory.id);
44+
maybePushHttpLoggingMessage(ScreenMetaData.memory.id);
4545
});
4646
}
4747
}

packages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,13 @@ class _FlutterFramesChartState extends State<_FlutterFramesChart> {
123123
);
124124
bannerMessages.addMessage(
125125
ShaderJankMessage(
126-
offlineDataController.showingOfflineData.value
127-
? ScreenMetaData.simple.id
128-
: ScreenMetaData.performance.id,
126+
screenId:
127+
offlineDataController.showingOfflineData.value
128+
? ScreenMetaData.simple.id
129+
: ScreenMetaData.performance.id,
129130
jankyFramesCount: shaderJankFrames.length,
130131
jankDuration: shaderJankDuration,
131-
).build(context),
132+
),
132133
);
133134
}
134135
}

packages/devtools_app/lib/src/screens/performance/performance_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class PerformanceScreenBodyState extends State<PerformanceScreenBody>
7373
@override
7474
void didChangeDependencies() {
7575
super.didChangeDependencies();
76-
maybePushDebugModePerformanceMessage(context, PerformanceScreen.id);
76+
maybePushDebugModePerformanceMessage(PerformanceScreen.id);
7777
}
7878

7979
@override

packages/devtools_app/lib/src/screens/profiler/profiler_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class _ProfilerScreenBodyState extends State<ProfilerScreenBody>
9696
@override
9797
void didChangeDependencies() {
9898
super.didChangeDependencies();
99-
maybePushDebugModePerformanceMessage(context, ProfilerScreen.id);
99+
maybePushDebugModePerformanceMessage(ProfilerScreen.id);
100100
}
101101

102102
@override

0 commit comments

Comments
 (0)