Remove scaleByFontFactor method and usages (#9304)

Author: elliette

packages/devtools_app/lib/src/extensions/embedded/_view_web.dart

@@ -311,7 +311,7 @@ class _ExtensionIFrameController extends DisposableController
       buildTextSpans: (_) => [
         TextSpan(
           text: showBannerMessageEvent.message,
-          style: TextStyle(fontSize: defaultFontSize),
+          style: const TextStyle(fontSize: defaultFontSize),
         ),
       ],
     );

packages/devtools_app/lib/src/extensions/extension_screen_controls.dart

@@ -183,7 +183,7 @@ class DisableExtensionDialog extends StatelessWidget {
                   text: 'DevTools Extensions ',
                   style: theme.boldTextStyle,
                 ),
-                WidgetSpan(
+                const WidgetSpan(
                   child: Icon(Icons.extension_rounded, size: defaultIconSize),
                 ),
                 const TextSpan(text: ' menu.'),

packages/devtools_app/lib/src/extensions/extension_settings.dart

@@ -48,9 +48,7 @@ class ExtensionSettingsDialog extends StatelessWidget {
   Widget build(BuildContext context) {
     final theme = Theme.of(context);
     // This dialog needs a fixed height because it contains a scrollable list.
-    final dialogHeight = anyTestMode
-        ? scaleByFontFactor(1000.0)
-        : scaleByFontFactor(300.0);
+    final dialogHeight = anyTestMode ? 1000.0 : 300.0;
     return DevToolsDialog(
       title: const DialogTitleText('DevTools Extensions'),
       content: SizedBox(

packages/devtools_app/lib/src/framework/home_screen.dart

@@ -82,8 +82,8 @@ class _HomeScreenBodyState extends State<HomeScreenBody> with AutoDisposeMixin {
 class ConnectionSection extends StatelessWidget {
   const ConnectionSection({super.key, required this.connected});
 
-  static const _primaryMinScreenWidthForTextBeforeScaling = 480.0;
-  static const _secondaryMinScreenWidthForTextBeforeScaling = 600.0;
+  static const _primaryMinScreenWidthForText = 480.0;
+  static const _secondaryMinScreenWidthForText = 600.0;
 
   final bool connected;
 
@@ -95,14 +95,12 @@ class ConnectionSection extends StatelessWidget {
         actions: [
           ViewVmFlagsButton(
             gaScreen: gac.home,
-            minScreenWidthForTextBeforeScaling:
-                _secondaryMinScreenWidthForTextBeforeScaling,
+            minScreenWidthForText: _secondaryMinScreenWidthForText,
           ),
           const SizedBox(width: defaultSpacing),
           ConnectToNewAppButton(
             gaScreen: gac.home,
-            minScreenWidthForTextBeforeScaling:
-                _primaryMinScreenWidthForTextBeforeScaling,
+            minScreenWidthForText: _primaryMinScreenWidthForText,
             routerDelegate: DevToolsRouterDelegate.of(context),
             onPressed: () =>
                 Navigator.of(context, rootNavigator: true).pop('dialog'),
@@ -202,7 +200,7 @@ class _ConnectInputState extends State<ConnectInput> with BlockingActionMixin {
           children: [
             SizedBox(
               height: defaultTextFieldHeight,
-              width: scaleByFontFactor(350.0),
+              width: 350.0,
               child: DevToolsClearableTextField(
                 labelText: 'URL',
                 onSubmitted: actionInProgress

packages/devtools_app/lib/src/framework/notifications_view.dart

@@ -14,7 +14,7 @@ import '../shared/managers/notifications.dart';
 import '../shared/primitives/utils.dart';
 import '../shared/ui/common_widgets.dart';
 
-double get _notificationHeight => scaleByFontFactor(175.0);
+const _notificationHeight = 175.0;
 final _notificationWidth = _notificationHeight * goldenRatio;
 
 /// Manager for notifications in the app.
@@ -151,7 +151,7 @@ class _NotificationOverlay extends StatelessWidget {
       child: Padding(
         // Position the notifications in the lower right of the app window, and
         // high enough up that we don't obscure the status line.
-        padding: EdgeInsets.only(
+        padding: const EdgeInsets.only(
           right: defaultSpacing,
           bottom: statusLineHeight + defaultSpacing,
         ),

packages/devtools_app/lib/src/framework/observer/memory_observer.dart

@@ -231,10 +231,10 @@ class _ReduceMemoryButtonState extends State<_ReduceMemoryButton> {
           child: Padding(
             padding: const EdgeInsets.symmetric(horizontal: denseSpacing),
             child: inProgress
-                ? SizedBox(
+                ? const SizedBox(
                     height: actionsIconSize,
                     width: actionsIconSize,
-                    child: const CircularProgressIndicator(),
+                    child: CircularProgressIndicator(),
                   )
                 : ValueListenableBuilder(
                     valueListenable: result,

packages/devtools_app/lib/src/framework/scaffold/app_bar.dart

@@ -59,7 +59,7 @@ class DevToolsAppBar extends StatelessWidget {
     if (screens.isNotEmpty && actionsWithSpacer.isNotEmpty) {
       actionsWithSpacer.insert(
         0,
-        VerticalLineSpacer(height: defaultToolbarHeight),
+        const VerticalLineSpacer(height: defaultToolbarHeight),
       );
     }
 
@@ -219,7 +219,7 @@ class TabOverflowButton extends StatelessWidget {
 
 @visibleForTesting
 class SelectedTabWrapper extends StatelessWidget {
-  SelectedTabWrapper({super.key, required this.child, double? width})
+  const SelectedTabWrapper({super.key, required this.child, double? width})
     : width = width ?? buttonMinWidth;
 
   final Widget child;

packages/devtools_app/lib/src/framework/scaffold/scaffold.dart

@@ -327,7 +327,9 @@ class DevToolsScaffoldState extends State<DevToolsScaffold>
             child: Scaffold(
               appBar: showAppBar
                   ? PreferredSize(
-                      preferredSize: Size.fromHeight(defaultToolbarHeight),
+                      preferredSize: const Size.fromHeight(
+                        defaultToolbarHeight,
+                      ),
                       // Place the AppBar inside of a Hero widget to keep it the same across
                       // route transitions.
                       child: Hero(

packages/devtools_app/lib/src/framework/scaffold/settings_dialog.dart

@@ -107,7 +107,7 @@ class SettingsDialog extends StatelessWidget {
 class _VerboseLoggingSetting extends StatelessWidget {
   const _VerboseLoggingSetting();
 
-  static const _minScreenWidthForTextBeforeScaling = 500.0;
+  static const _minScreenWidthForText = 500.0;
 
   @override
   Widget build(BuildContext context) {
@@ -130,8 +130,7 @@ class _VerboseLoggingSetting extends StatelessWidget {
               icon: Icons.copy_outlined,
               gaScreen: gac.settingsDialog,
               gaSelection: gac.copyLogs,
-              minScreenWidthForTextBeforeScaling:
-                  _minScreenWidthForTextBeforeScaling,
+              minScreenWidthForText: _minScreenWidthForText,
               onPressed: () async => await copyToClipboard(
                 LogStorage.root.toString(),
                 successMessage: 'Successfully copied logs',
@@ -142,8 +141,7 @@ class _VerboseLoggingSetting extends StatelessWidget {
               label: 'Clear logs',
               gaScreen: gac.settingsDialog,
               gaSelection: gac.clearLogs,
-              minScreenWidthForTextBeforeScaling:
-                  _minScreenWidthForTextBeforeScaling,
+              minScreenWidthForText: _minScreenWidthForText,
               onPressed: LogStorage.root.clear,
             ),
           ],

packages/devtools_app/lib/src/framework/scaffold/status_line.dart

@@ -190,7 +190,7 @@ class StatusLine extends StatelessWidget {
         }
       },
       child: screenWidth <= MediaSize.xxs
-          ? DevToolsTooltip(
+          ? const DevToolsTooltip(
               message: noConnectionMsg,
               child: Icon(Icons.warning_amber_rounded, size: actionsIconSize),
             )