Debug levels

[garak]

The docs state that the valid values for setDebug are 0,1,2,3 but the source code states that valid values are -1, 0, 1, and 2. Which one is correct?

It would be nice to add class constants for those values, anyway.

[gggeek]

I know it's a bit confusing, but I think that both code and docs are correct ;-)

The thing is: the Server understands values 0 to 3, while the Client (well, the Request actually, as the Client passes the debug level down to it) understands values -1 to 2.

The reason for this discrepancy is the same as always: organic growth over time and wanting to keep BC at all costs while introducing new features.

As for introducing constants: it might be a good idea. I don't know which names would make sense though. Names such as SILENT, VERBOSE, VERY_VERBOSE could be used, but they would only alleviate the issue with passing in unsupported values, they would not be a clear indicator to the developer of their intended usage / effects...

[gggeek]

ps: I might also update the docs with a phrase about the Client accepting different debug levels than the Server...