Skip to content

Commit e0ef0f3

Browse files
committed
rn-130: Some tiny fixes and rephrasings.
1 parent b9f1343 commit e0ef0f3

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

rev_news/drafts/edition-130.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ This edition covers what happened during the months of November and December 202
4141

4242
In early November, David returned to the thread reporting that the
4343
issue persisted in Git 2.51.2. He provided a specific reproduction
44-
case involving a bare clone of `bind9`. The output showed that one
44+
case involving a bare clone of the [`bind9` source repository](https://gitlab.isc.org/isc-projects/bind9).
45+
The output showed that one
4546
tag update was rejected (with a `would clobber existing tag` error),
4647
and consequently, all other valid new tags (`v9.18.41`, etc.)
4748
failed to appear in the repository, despite being listed as "new
@@ -50,11 +51,11 @@ This edition covers what happened during the months of November and December 202
5051
Randall S. Becker suggested using `git fetch --tags --force` to
5152
clear the situation. David Bohman replied that while he could
5253
reproduce it locally, the key behavioral change was that prior to
53-
2.51, Git would fail the conflicting tag but still insert the
54+
version 2.51, Git would fail regarding the conflicting tag but still insert the
5455
non-conflicting ones.
5556

56-
Chris Torek identified the root cause as the new reference
57-
transaction system introduced in recent versions. He noted that the
57+
Chris Torek identified the new reference transaction system
58+
introduced in recent versions as the root cause. He noted that the
5859
behavior had shifted to "all or nothing" (either all tags get
5960
updated, or none do) and questioned which behavior was actually
6061
buggy. David Bohman argued that this was a risky change for a mature
@@ -73,8 +74,7 @@ This edition covers what happened during the months of November and December 202
7374
fetching tags, if a conflict occurs, the function
7475
`fetch_and_consume_refs()` returns an error code immediately. This
7576
caused the code to jump to the cleanup section, skipping the commit
76-
of the transaction entirely, meaning even valid updates were
77-
discarded.
77+
of the transaction entirely, and thus discarding even valid updates.
7878

7979
The proposed fix involved extracting the transaction commit logic
8080
into a new function, `commit_ref_transaction()`, and ensuring it is
@@ -102,7 +102,7 @@ This edition covers what happened during the months of November and December 202
102102
user does not specify `--tags` or `--no-tags`, confirming Patrick's
103103
understanding.
104104

105-
Patrick noted that the code now had three different callsites
105+
Patrick noted that the code now had three different call sites
106106
committing the transaction and felt it was "somewhat fragile."
107107
Justin pointed out that the return code of
108108
`commit_ref_transaction()` was being ignored in the new
@@ -179,7 +179,7 @@ This edition covers what happened during the months of November and December 202
179179

180180
The small patch series was eventually merged, and should be part of
181181
Git 2.53.0 that should be released at the latest towards the
182-
beginning of February 2026. With this not only the transaction logic
182+
beginning of February 2026. With this version, not only the transaction logic
183183
will be fixed, but related regressions regarding post-fetch
184184
operations (like updating `FETCH_HEAD`) will also have been
185185
identified and resolved.
@@ -190,11 +190,11 @@ This edition covers what happened during the months of November and December 202
190190
* **Who are you and what do you do?**
191191

192192
My name is Lucas Oshiro, I'm one of the three
193-
GSoC '25 participants working on Git. I'm from São Paulo, Brazil
194-
and I'm a bachelor and master in Computer Science from the
193+
GSoC '25 participants working on Git. I'm from São Paulo, Brazil,
194+
and I hold bachelor and master degrees in Computer Science from the
195195
[University of São Paulo](https://www5.usp.br/#english). I don't
196196
have only one specific interest in programming topics, I enjoy
197-
several different topics, like: lower-lever C code (like we do for Git),
197+
several different topics, like lower-lever C code (like we do for Git),
198198
FP languages (especially Haskell), play with network simulators, data
199199
analysis, operating systems, databases and so on.
200200

@@ -207,14 +207,14 @@ This edition covers what happened during the months of November and December 202
207207
who participated in [GSoC '19 on Git](https://summerofcode.withgoogle.com/archive/2019/projects/4787791739748352).
208208
At the time, we needed to study a vulnerability and how it was fixed.
209209
We chose [CVE-2017-1000117](https://nvd.nist.gov/vuln/detail/cve-2017-1000117),
210-
which was vulnerability in Git. That was my first time reading Git
210+
which was a vulnerability in Git. That was my first time reading Git
211211
source code.
212212

213-
Two years later, I was a member of [group focused on contributing to Free/Open-Source software](https://flusp.ime.usp.br)
213+
Two years later, I was a member of a [group focused on contributing to Free/Open-Source software](https://flusp.ime.usp.br)
214214
at my University. I sent a patch to Git at the time, but I needed to
215215
focus on other stuff and I couldn't finish it.
216216

217-
After that, I started to work as a back-end software engineer and I
217+
After that, I started to work as a back-end software engineer and
218218
witnessed several Git-related problems. My two previous experiences with
219219
Git's source code made me want to understand what was happening and
220220
delving into its internals, so I could help other developers from my
@@ -265,7 +265,7 @@ This edition covers what happened during the months of November and December 202
265265
* **What was the biggest challenge you faced during your contributions
266266
to Git, and how did you overcome it?**
267267

268-
I think that the biggest challenge was the complete redesigns of
268+
I think that the biggest challenge was the complete redesign of
269269
`git repo info` during the GSoC period, which made me re-write it from
270270
scratch several times. I think this was a consequence of my previous
271271
answer and that this challenge was solved itself.
@@ -286,7 +286,7 @@ This edition covers what happened during the months of November and December 202
286286

287287
Perhaps commands that accumulate responsibilities, like `git checkout`,
288288
`git reset` and `git rev-parse`. They make sense from the Git
289-
perspective, but I think they are confusing from the users
289+
perspective, but I think they are confusing from the users'
290290
perspective.
291291

292292
* **What upcoming features or changes in Git are you particularly
@@ -299,7 +299,7 @@ This edition covers what happened during the months of November and December 202
299299
and useful as a data storage, if done correctly. Currently we do that
300300
through interactive rebase but I think it can be intimidating for less
301301
experienced users. Jujutsu proposes a more straightforward way to do
302-
that and it's nice to see Patrick bringing it to Git.
302+
that, and it's nice to see Patrick bringing it to Git.
303303

304304
- Justin Tobler's [new `git repo structure` command](https://public-inbox.org/git/[email protected]/):
305305
of course I'm interested in this subcommand since it is the sibling of
@@ -328,15 +328,15 @@ This edition covers what happened during the months of November and December 202
328328
GMail filters for classifying the messages (patches, What's Cooking and
329329
Rev News announcements).
330330

331-
However, those mail clients don't have code syntax highlighting and it's
331+
However, those mail clients don't have code syntax highlighting, and it's
332332
hard to read the patches inside them. For that purpose, I use
333333
[patch-hub](https://github.com/kworkflow/patch-hub), a TUI for reviewing
334334
patches from kernel mailing lists (including Git).
335335

336336
* **How do you envision your own involvement with Git or other open
337337
source projects in the future?**
338338

339-
There are some things I want to finish in `git repo info` and I
339+
There are some things I want to finish in `git repo info`, and I
340340
still send patches for it. I enjoyed contributing to Git and I
341341
don't want to stop here.
342342

0 commit comments

Comments
 (0)