Use type cast to make QL more succinct

owen-mc · owen-mc · commit 16113e655078 · 2026-01-14T11:50:56.000Z
diff --git a/go/ql/src/Security/CWE-352/ConstantOauth2State.ql b/go/ql/src/Security/CWE-352/ConstantOauth2State.ql
@@ -140,9 +140,7 @@ predicate privateUrlFlowsToAuthCodeUrlCall(DataFlow::CallNode call) {
 
 module FlowToPrintConfig implements DataFlow::ConfigSig {
   additional predicate isSinkCall(DataFlow::Node sink, DataFlow::CallNode call) {
-    exists(LoggerCall logCall | call = logCall |
-      sink = logCall.getAValueFormattedMessageComponent()
-    )
+    sink = call.(LoggerCall).getAValueFormattedMessageComponent()
   }
 
   predicate isSource(DataFlow::Node source) { source = any(AuthCodeUrl m).getACall().getResult() }

Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,7 @@ predicate privateUrlFlowsToAuthCodeUrlCall(DataFlow::CallNode call) {`
`140`	`140`
`141`	`141`	`module FlowToPrintConfig implements DataFlow::ConfigSig {`
`142`	`142`	`additional predicate isSinkCall(DataFlow::Node sink, DataFlow::CallNode call) {`
`143`		`- exists(LoggerCall logCall \| call = logCall \|`
`144`		`- sink = logCall.getAValueFormattedMessageComponent()`
`145`		`- )`
	`143`	`+ sink = call.(LoggerCall).getAValueFormattedMessageComponent()`
`146`	`144`	`}`
`147`	`145`
`148`	`146`	`predicate isSource(DataFlow::Node source) { source = any(AuthCodeUrl m).getACall().getResult() }`