Skip to content

Commit b3285c6

Browse files
committed
Make description of acceptingvalue column clearer
1 parent 5451424 commit b3285c6

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,8 @@
9191
* - flow from the _second_ indirection of the 0th argument to the first
9292
* indirection of the return value, etc.
9393
* 8. The `acceptingvalue` column of barrier guard models specifies the condition
94-
* under which the guard accepts or blocks flow. It can be one of "true" or
95-
* "false". In the future "no-exception", "not-zero", "null", "not-null" may be
96-
* supported.
94+
* under which the guard blocks flow. It can be one of "true" or "false". In
95+
* the future "no-exception", "not-zero", "null", "not-null" may be supported.
9796
* 9. The `kind` column is a tag that can be referenced from QL to determine to
9897
* which classes the interpreted elements should be added. For example, for
9998
* sources "remote" indicates a default remote flow source, and for summaries

csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@
7474
* - "Property[p]": Selects the contents of property `p`.
7575
*
7676
* 8. The `acceptingvalue` column of barrier guard models specifies the condition
77-
* under which the guard accepts or blocks flow. It can be one of "true" or
78-
* "false", "no-exception", "not-zero", "null", "not-null".
77+
* under which the guard blocks flow. It can be one of "true" or "false". In
78+
* the future "no-exception", "not-zero", "null", "not-null" may be supported.
7979
* 9. The `kind` column is a tag that can be referenced from QL to determine to
8080
* which classes the interpreted elements should be added. For example, for
8181
* sources "remote" indicates a default remote flow source, and for summaries

go/ql/lib/semmle/go/dataflow/ExternalFlow.qll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,8 @@
8383
* - "Dereference": Selects the value referenced by a pointer.
8484
*
8585
* 8. The `acceptingvalue` column of barrier guard models specifies the condition
86-
* under which the guard accepts or blocks flow. It can be one of "true" or
87-
* "false". In the future "no-exception", "not-zero", "null", "not-null" may be
88-
* supported.
86+
* under which the guard blocks flow. It can be one of "true" or "false". In
87+
* the future "no-exception", "not-zero", "null", "not-null" may be supported.
8988
* 9. The `kind` column is a tag that can be referenced from QL to determine to
9089
* which classes the interpreted elements should be added. For example, for
9190
* sources "remote" indicates a default remote flow source, and for summaries

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@
7474
* - "ReturnValue": Selects the return value of a call to the selected element.
7575
* - "Element": Selects the collection elements of the selected element.
7676
* 8. The `acceptingvalue` column of barrier guard models specifies the condition
77-
* under which the guard accepts or blocks flow. It can be one of "true" or
78-
* "false", "no-exception", "not-zero", "null", "not-null".
77+
* under which the guard blocks flow. It can be one of "true" or "false". In
78+
* the future "no-exception", "not-zero", "null", "not-null" may be supported.
7979
* 9. The `kind` column is a tag that can be referenced from QL to determine to
8080
* which classes the interpreted elements should be added. For example, for
8181
* sources "remote" indicates a default remote flow source, and for summaries

0 commit comments

Comments
 (0)