Skip to content

Commit ba6e981

Browse files
committed
Add unit tests for PR #212 review findings and fix compilation errors from generated type changes
SessionRequestBuilderTest.java (+48): - Add testBuildCreateRequestPropagatesCloudSessionOptions: verifies CloudSessionOptions (repository name/ID) are wired through SessionRequestBuilder into the create request JSON. - Add testBuildCreateRequestOmitsCloudWhenNull: verifies cloud field is omitted when not set. - Add testCloudSessionOptionsSerializesCorrectly: verifies Jackson serialization round-trip of CloudSessionOptions with repository fields. SessionHandlerTest.java (+48): - Add testHookInputSessionIdDeserializedForSessionStart: verifies sessionId is deserialized from JSON for session.start hook inputs. - Add testHookInputSessionIdDeserializedForSessionEnd: same for session.end hook inputs. - Add testHookInputSessionIdDeserializedForUserPromptSubmitted: same for user_prompt_submitted hook inputs. DataObjectCoverageTest.java (+58): - Add assertNull(input.getSessionId()) to preToolUseHookInputGetters and postToolUseHookInputGetters to verify sessionId getter exists and defaults to null. - Add preToolUseHookInputSessionIdRoundTrip: verifies setSessionId/getSessionId round-trip. - Add postToolUseHookInputSessionIdRoundTrip: same for PostToolUseHookInput. - Add customAgentConfigModelGetterAndSetter: verifies model getter/setter on CustomAgentConfig. - Add customAgentConfigModelFluentChaining: verifies fluent setter returns same instance. - Add customAgentConfigModelSerializationRoundTrip: verifies Jackson serialization of model. - Add customAgentConfigModelOmittedWhenNull: verifies model omitted from JSON when null. RpcWrappersTest.java (+1, -1): - Fix SessionModelSwitchToParams constructor call: add 5th null argument for new reasoningSummary parameter added by codegen. SessionEventHandlingTest.java (+2, -2): - Fix SessionStartEventData construction: add 12th null argument for new detachedFromSpawningParentSessionId field added by codegen. GeneratedRpcApiCoverageTest.java (+3, -2): - Fix SessionFsSetProviderParams constructor: add 4th null argument for new capabilities field. - Add assertNull(params.capabilities()) to verify the new field accessor. GeneratedRpcRecordsCoverageTest.java (+11, -10): - Fix SessionModelSwitchToParams: add 5th null arg, add assertNull for reasoningSummary. - Fix SkillDefinition: use SkillSource.PROJECT enum instead of raw "project" string. - Fix DiscoveredMcpServer: use McpServerSource.USER enum instead of DiscoveredMcpServerSource.USER. - Fix ModelPolicyRecord: use ModelPolicyState.ENABLED enum instead of raw "active" string. - Fix ModelPolicyRecord dateAdded: use OffsetDateTime.parse() instead of raw string.
1 parent f8b9f28 commit ba6e981

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

src/main/java/com/github/copilot/sdk/CopilotSession.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1706,7 +1706,8 @@ public CompletableFuture<Void> setModel(String model, String reasoningEffort,
17061706
generatedCapabilities = new ModelCapabilitiesOverride(supports, limits);
17071707
}
17081708
return getRpc().model
1709-
.switchTo(new SessionModelSwitchToParams(sessionId, model, reasoningEffort, null, generatedCapabilities))
1709+
.switchTo(
1710+
new SessionModelSwitchToParams(sessionId, model, reasoningEffort, null, generatedCapabilities))
17101711
.thenApply(r -> null);
17111712
}
17121713

src/test/java/com/github/copilot/sdk/SessionRequestBuilderTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -668,8 +668,8 @@ void testResumeRequestSerializesModeFlags() throws Exception {
668668

669669
@Test
670670
void testBuildCreateRequestPropagatesCloudSessionOptions() throws Exception {
671-
var cloud = new CloudSessionOptions().setRepository(
672-
new CloudSessionRepository().setOwner("my-org").setName("my-repo").setBranch("main"));
671+
var cloud = new CloudSessionOptions()
672+
.setRepository(new CloudSessionRepository().setOwner("my-org").setName("my-repo").setBranch("main"));
673673
var config = new SessionConfig().setCloud(cloud);
674674

675675
CreateSessionRequest request = SessionRequestBuilder.buildCreateRequest(config);
@@ -694,8 +694,8 @@ void testBuildCreateRequestOmitsCloudWhenNull() throws Exception {
694694

695695
@Test
696696
void testCloudSessionOptionsSerializesCorrectly() throws Exception {
697-
var cloud = new CloudSessionOptions().setRepository(
698-
new CloudSessionRepository().setOwner("acme").setName("widgets").setBranch("feature-1"));
697+
var cloud = new CloudSessionOptions()
698+
.setRepository(new CloudSessionRepository().setOwner("acme").setName("widgets").setBranch("feature-1"));
699699
var config = new SessionConfig().setCloud(cloud);
700700

701701
CreateSessionRequest request = SessionRequestBuilder.buildCreateRequest(config);

src/test/java/com/github/copilot/sdk/generated/rpc/GeneratedRpcRecordsCoverageTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,8 @@ void sessionsForkResult_record() {
872872

873873
@Test
874874
void accountGetQuotaResult_nested() {
875-
var snapshot = new AccountQuotaSnapshot(null, 100L, 40L, null, 60.0, 5.0, true, java.time.OffsetDateTime.parse("2026-05-01T00:00:00Z"));
875+
var snapshot = new AccountQuotaSnapshot(null, 100L, 40L, null, 60.0, 5.0, true,
876+
java.time.OffsetDateTime.parse("2026-05-01T00:00:00Z"));
876877
var result = new AccountGetQuotaResult(Map.of("chat", snapshot));
877878
assertEquals(1, result.quotaSnapshots().size());
878879
var s = result.quotaSnapshots().get("chat");
@@ -893,8 +894,8 @@ void mcpConfigListResult_record() {
893894

894895
@Test
895896
void mcpDiscoverResult_nested() {
896-
var server = new DiscoveredMcpServer("discovered-server", DiscoveredMcpServerType.STDIO,
897-
McpServerSource.USER, true);
897+
var server = new DiscoveredMcpServer("discovered-server", DiscoveredMcpServerType.STDIO, McpServerSource.USER,
898+
true);
898899
var result = new McpDiscoverResult(List.of(server));
899900
assertEquals(1, result.servers().size());
900901
assertEquals("discovered-server", result.servers().get(0).name());

0 commit comments

Comments
 (0)