Fix add-wizard auth failure when git remote uses HTTPS URL with embedded username (#25375)

Author: Copilot

pkg/cli/git.go

@@ -3,6 +3,7 @@ package cli
 import (
 	"errors"
 	"fmt"
+	"net/url"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -86,12 +87,26 @@ func parseGitHubRepoSlugFromURL(url string) string {
 // Supports HTTPS (https://host[:port]/path), HTTP (http://host[:port]/path), and SSH (git@host[:port]:path or ssh://git@host[:port]/path) formats.
 // Returns the host portion as "host[:port]" when parsed, or "github.com" as the default if the URL cannot be parsed.
 func extractHostFromRemoteURL(remoteURL string) string {
-	// HTTPS / HTTP format: https://host/path or http://host/path
+	// HTTPS / HTTP format: https://[userinfo@]host/path or http://[userinfo@]host/path
+	// Use net/url.Parse to correctly handle all userinfo variants (user@, user:pass@,
+	// and passwords containing '@') and to extract the bare host without credentials.
 	for _, scheme := range []string{"https://", "http://"} {
-		if after, ok := strings.CutPrefix(remoteURL, scheme); ok {
+		if strings.HasPrefix(remoteURL, scheme) {
+			if u, err := url.Parse(remoteURL); err == nil && u.Host != "" {
+				return u.Host
+			}
+			// Fallback: strip scheme and any userinfo manually.
+			after := remoteURL[len(scheme):]
 			if host, _, found := strings.Cut(after, "/"); found {
+				// Strip optional userinfo (everything up to and including the last '@').
+				if idx := strings.LastIndex(host, "@"); idx >= 0 {
+					host = host[idx+1:]
+				}
 				return host
 			}
+			if idx := strings.LastIndex(after, "@"); idx >= 0 {
+				return after[idx+1:]
+			}
 			return after
 		}
 	}

pkg/cli/git_test.go

@@ -460,6 +460,26 @@ func TestExtractHostFromRemoteURL(t *testing.T) {
 		url      string
 		expected string
 	}{
+		{
+			name:     "HTTPS with embedded username (Windows-style)",
+			url:      "https://bryanknox@github.com/owner/repo.git",
+			expected: "github.com",
+		},
+		{
+			name:     "HTTPS with embedded username on GHES",
+			url:      "https://user@ghes.example.com/org/repo.git",
+			expected: "ghes.example.com",
+		},
+		{
+			name:     "HTTP with embedded username",
+			url:      "http://user@ghes.example.com/org/repo.git",
+			expected: "ghes.example.com",
+		},
+		{
+			name:     "HTTPS with embedded username and password",
+			url:      "https://user:pass@github.com/owner/repo.git",
+			expected: "github.com",
+		},
 		{
 			name:     "public GitHub HTTPS",
 			url:      "https://github.com/owner/repo.git",