fix

Author: sushanb

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/MetricsImpl.java

@@ -97,7 +97,8 @@ public MetricsImpl(
       this.internalRecorder = metricRegistry.newRecorderRegistry(internalOtel.getMeterProvider());
       this.pacemaker = new Pacemaker(internalRecorder, clientInfo, "background");
       this.channelPoolMetricsTracer = new ChannelPoolMetricsTracer(internalRecorder, clientInfo);
-      this.directPathCompatibleTracer = new DefaultDirectPathCompatibleTracer(clientInfo, internalRecorder);
+      this.directPathCompatibleTracer =
+          new DefaultDirectPathCompatibleTracer(clientInfo, internalRecorder);
       this.grpcOtel =
           GrpcOpenTelemetry.newBuilder()
               .sdk(internalOtel)

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/DefaultDirectPathCompatibleTracer.java

@@ -21,22 +21,22 @@
 
 @InternalApi
 public class DefaultDirectPathCompatibleTracer implements DirectPathCompatibleTracer {
-    private final ClientInfo clientInfo;
-    private final MetricRegistry.RecorderRegistry recorder;
+  private final ClientInfo clientInfo;
+  private final MetricRegistry.RecorderRegistry recorder;
 
-    public DefaultDirectPathCompatibleTracer(
-            ClientInfo clientInfo, MetricRegistry.RecorderRegistry recorder) {
-        this.clientInfo = clientInfo;
-        this.recorder = recorder;
-    }
+  public DefaultDirectPathCompatibleTracer(
+      ClientInfo clientInfo, MetricRegistry.RecorderRegistry recorder) {
+    this.clientInfo = clientInfo;
+    this.recorder = recorder;
+  }
 
-    @Override
-    public void recordSuccess(String ipPreference) {
-        recorder.dpCompatGuage.recordSuccess(clientInfo, ipPreference);
-    }
+  @Override
+  public void recordSuccess(String ipPreference) {
+    recorder.dpCompatGuage.recordSuccess(clientInfo, ipPreference);
+  }
 
-    @Override
-    public void recordFailure(String reason) {
-        recorder.dpCompatGuage.recordFailure(clientInfo, reason);
-    }
+  @Override
+  public void recordFailure(String reason) {
+    recorder.dpCompatGuage.recordFailure(clientInfo, reason);
+  }
 }

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/DirectPathCompatibleTracer.java

@@ -17,23 +17,21 @@
 
 import com.google.api.core.InternalApi;
 
-/**
- * Interface for recording DirectPath/DirectAccess eligibility metrics.
- */
+/** Interface for recording DirectPath/DirectAccess eligibility metrics. */
 @InternalApi
 public interface DirectPathCompatibleTracer {
 
-    /**
-     * Records that the environment is eligible and successfully connected via DirectPath.
-     *
-     * @param ipPreference The IP preference used (e.g., "ipv6").
-     */
-    void recordSuccess(String ipPreference);
+  /**
+   * Records that the environment is eligible and successfully connected via DirectPath.
+   *
+   * @param ipPreference The IP preference used (e.g., "ipv6").
+   */
+  void recordSuccess(String ipPreference);
 
-    /**
-     * Records that the environment is not eligible or failed to connect via DirectPath.
-     *
-     * @param reason The reason for the failure (e.g., "routing_check_failed").
-     */
-    void recordFailure(String reason);
-}
+  /**
+   * Records that the environment is not eligible or failed to connect via DirectPath.
+   *
+   * @param reason The reason for the failure (e.g., "routing_check_failed").
+   */
+  void recordFailure(String reason);
+}

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelFactory.java

@@ -17,10 +17,9 @@
 
 import com.google.api.core.InternalApi;
 import io.grpc.ManagedChannel;
-
 import java.io.IOException;
 
 @InternalApi
 public interface BigtableChannelFactory {
-    ManagedChannel createSingleChannel() throws IOException;
+  ManagedChannel createSingleChannel() throws IOException;
 }

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java

@@ -32,7 +32,6 @@
 import io.grpc.Metadata;
 import io.grpc.Status;
 import io.grpc.auth.MoreCallCredentials;
-
 import java.io.IOException;
 import java.io.UnsupportedEncodingException;
 import java.net.URLEncoder;

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java

@@ -166,8 +166,8 @@ public static BigtableClientContext create(
               transportProvider.build(),
               channelPrimer,
               metrics.getChannelPoolMetricsTracer(),
-              backgroundExecutor,               metrics.getDirectPathCompatibleTracer()
-                  );
+              backgroundExecutor,
+              metrics.getDirectPathCompatibleTracer());
 
       builder.setTransportChannelProvider(btTransportProvider);
     }

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/DirectAccessChecker.java

@@ -17,18 +17,16 @@
 
 import com.google.api.core.InternalApi;
 import com.google.cloud.bigtable.data.v2.internal.csm.tracers.DirectPathCompatibleTracer;
-import io.grpc.Channel;
-
 import javax.annotation.Nullable;
 
 @InternalApi
 /* Evaluates whether a given channel supports Direct Access. */
 public interface DirectAccessChecker {
-    /**
-     * Evaluates if Direct Access is available by creating a test channel.
-     *
-     * @param channelFactory A factory to create the test channel
-     * @return true if the channel is eligible for Direct Access
-     */
-    boolean check(BigtableChannelFactory channelFactory, @Nullable DirectPathCompatibleTracer tracer);
+  /**
+   * Evaluates if Direct Access is available by creating a test channel.
+   *
+   * @param channelFactory A factory to create the test channel
+   * @return true if the channel is eligible for Direct Access
+   */
+  boolean check(BigtableChannelFactory channelFactory, @Nullable DirectPathCompatibleTracer tracer);
 }

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

@@ -244,21 +244,21 @@ public ClientOperationSettings getPerOpSettings() {
 
   /** Applies common pool, message size, and keep-alive settings to the provided builder. */
   private static InstantiatingGrpcChannelProvider.Builder commonTraits(
-          InstantiatingGrpcChannelProvider.Builder builder) {
+      InstantiatingGrpcChannelProvider.Builder builder) {
     return builder
-            .setChannelPoolSettings(
-                    ChannelPoolSettings.builder()
-                            .setInitialChannelCount(10)
-                            .setMinRpcsPerChannel(1)
-                            // Keep it conservative as we scale the channel size every 1min
-                            // and delta is 2 channels.
-                            .setMaxRpcsPerChannel(25)
-                            .setPreemptiveRefreshEnabled(true)
-                            .build())
-            .setMaxInboundMessageSize(MAX_MESSAGE_SIZE)
-            .setKeepAliveTime(Duration.ofSeconds(30)) // sends ping in this interval
-            .setKeepAliveTimeout(
-                    Duration.ofSeconds(10)); // wait this long before considering the connection dead
+        .setChannelPoolSettings(
+            ChannelPoolSettings.builder()
+                .setInitialChannelCount(10)
+                .setMinRpcsPerChannel(1)
+                // Keep it conservative as we scale the channel size every 1min
+                // and delta is 2 channels.
+                .setMaxRpcsPerChannel(25)
+                .setPreemptiveRefreshEnabled(true)
+                .build())
+        .setMaxInboundMessageSize(MAX_MESSAGE_SIZE)
+        .setKeepAliveTime(Duration.ofSeconds(30)) // sends ping in this interval
+        .setKeepAliveTimeout(
+            Duration.ofSeconds(10)); // wait this long before considering the connection dead
   }
 
   /** Returns a builder for the default ChannelProvider for this service. */
@@ -285,22 +285,21 @@ public static InstantiatingGrpcChannelProvider.Builder defaultGrpcTransportProvi
 
   /** Applies Direct Access traits (DirectPath & ALTS) to an existing builder. */
   public static InstantiatingGrpcChannelProvider.Builder applyDirectAccessTraits(
-          InstantiatingGrpcChannelProvider.Builder builder) {
+      InstantiatingGrpcChannelProvider.Builder builder) {
 
     builder
-            .setAttemptDirectPathXds()
-            .setAttemptDirectPath(true)
-            .setAllowNonDefaultServiceAccount(true);
+        .setAttemptDirectPathXds()
+        .setAttemptDirectPath(true)
+        .setAllowNonDefaultServiceAccount(true);
 
     if (!DIRECT_PATH_BOUND_TOKEN_DISABLED) {
       builder.setAllowHardBoundTokenTypes(
-              Collections.singletonList(InstantiatingGrpcChannelProvider.HardBoundTokenTypes.ALTS));
+          Collections.singletonList(InstantiatingGrpcChannelProvider.HardBoundTokenTypes.ALTS));
     }
 
     return builder;
   }
 
-
   @SuppressWarnings("WeakerAccess")
   public static TransportChannelProvider defaultTransportChannelProvider() {
     return defaultGrpcTransportProviderBuilder().build();

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/MetadataExtractorInterceptor.java

@@ -34,7 +34,6 @@
 import io.grpc.MethodDescriptor;
 import io.grpc.Status;
 import io.grpc.alts.AltsContextUtil;
-
 import java.net.Inet4Address;
 import java.net.Inet6Address;
 import java.net.InetSocketAddress;

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/UnaryDirectAccessChecker.java

@@ -22,63 +22,65 @@
 import io.grpc.Channel;
 import io.grpc.ClientInterceptors;
 import io.grpc.ManagedChannel;
-
-import javax.annotation.Nullable;
 import java.util.Optional;
 import java.util.logging.Level;
 import java.util.logging.Logger;
+import javax.annotation.Nullable;
 
 /**
- * Evaluates whether a given channel has Direct Access (DirectPath) routing
- * by executing a RPC and inspecting the response headers.
+ * Evaluates whether a given channel has Direct Access (DirectPath) routing by executing a RPC and
+ * inspecting the response headers.
  */
 @InternalApi
 public class UnaryDirectAccessChecker implements DirectAccessChecker {
-    private static final Logger LOG = Logger.getLogger(UnaryDirectAccessChecker.class.getName());
-    private final ChannelPrimer channelPrimer;
+  private static final Logger LOG = Logger.getLogger(UnaryDirectAccessChecker.class.getName());
+  private final ChannelPrimer channelPrimer;
 
-    private UnaryDirectAccessChecker(ChannelPrimer channelPrimer) {
-        this.channelPrimer = channelPrimer;
-    }
+  private UnaryDirectAccessChecker(ChannelPrimer channelPrimer) {
+    this.channelPrimer = channelPrimer;
+  }
 
-    public static UnaryDirectAccessChecker create(ChannelPrimer channelPrimer) {
-        return new UnaryDirectAccessChecker(channelPrimer);
-    }
+  public static UnaryDirectAccessChecker create(ChannelPrimer channelPrimer) {
+    return new UnaryDirectAccessChecker(channelPrimer);
+  }
 
-    @Override
-    public boolean check(BigtableChannelFactory channelFactory, @Nullable DirectPathCompatibleTracer tracer) {
-        ManagedChannel channel = null;
-        try {
-            channel = channelFactory.createSingleChannel();
-            MetadataExtractorInterceptor interceptor = new MetadataExtractorInterceptor();
-            Channel interceptedChannel = ClientInterceptors.intercept(channel, interceptor);
-            channelPrimer.primeChannel(interceptedChannel);
+  @Override
+  public boolean check(
+      BigtableChannelFactory channelFactory, @Nullable DirectPathCompatibleTracer tracer) {
+    ManagedChannel channel = null;
+    try {
+      channel = channelFactory.createSingleChannel();
+      MetadataExtractorInterceptor interceptor = new MetadataExtractorInterceptor();
+      Channel interceptedChannel = ClientInterceptors.intercept(channel, interceptor);
+      channelPrimer.primeChannel(interceptedChannel);
 
-            // Extract the sideband data populated by the interceptor
-            MetadataExtractorInterceptor.SidebandData sidebandData = interceptor.getSidebandData();
+      // Extract the sideband data populated by the interceptor
+      MetadataExtractorInterceptor.SidebandData sidebandData = interceptor.getSidebandData();
 
-            boolean isEligible =  Optional.ofNullable(sidebandData)
-                    .map(MetadataExtractorInterceptor.SidebandData::getPeerInfo)
-                    .map(PeerInfo::getTransportType)
-                    .map(type -> type == PeerInfo.TransportType.TRANSPORT_TYPE_DIRECT_ACCESS)
-                    .orElse(false);
+      boolean isEligible =
+          Optional.ofNullable(sidebandData)
+              .map(MetadataExtractorInterceptor.SidebandData::getPeerInfo)
+              .map(PeerInfo::getTransportType)
+              .map(type -> type == PeerInfo.TransportType.TRANSPORT_TYPE_DIRECT_ACCESS)
+              .orElse(false);
 
-            if (isEligible && tracer != null) {
-                String ipProtocolStr = Optional.ofNullable(sidebandData)
-                        .map(MetadataExtractorInterceptor.SidebandData::getIpProtocol)
-                        .map(String::valueOf)
-                        .map(String::toLowerCase)
-                        .orElse("unknown");
-                tracer.recordSuccess(ipProtocolStr);
-            }
-            return isEligible;
-        } catch (Exception e) {
-            LOG.log(Level.FINE, "Failed to evaluate direct access eligibility.", e);
-            return false;
-        } finally {
-            if (channel != null) {
-                channel.shutdownNow();
-            }
-        }
+      if (isEligible && tracer != null) {
+        String ipProtocolStr =
+            Optional.ofNullable(sidebandData)
+                .map(MetadataExtractorInterceptor.SidebandData::getIpProtocol)
+                .map(String::valueOf)
+                .map(String::toLowerCase)
+                .orElse("unknown");
+        tracer.recordSuccess(ipProtocolStr);
+      }
+      return isEligible;
+    } catch (Exception e) {
+      LOG.log(Level.FINE, "Failed to evaluate direct access eligibility.", e);
+      return false;
+    } finally {
+      if (channel != null) {
+        channel.shutdownNow();
+      }
     }
+  }
 }