DataplaneAPI doesn't provide a skipReload for `CreateStorageSSLCertificate`

[fjaeckel]

I'm currently working with DataplaneAPI and have been stumbling over the fact that a POST /services/haproxy/storage/ssl_certificates reloads HAProxy unexpectedly.

The endpoint only provides a force_reload and not a skip_reload option, when all other endpoints support that feature.

dataplaneapi/handlers/ssl_cert_storage.go

Lines 278 to 281 in 1b63b07

	forceReload := false
	if params.ForceReload != nil {
	forceReload = *params.ForceReload
	}

I was wondering if there is a definitive non-obvious reason for this, or if its just a "no-one made the change yet" situation.

The code looks to mirror the situation:

dataplaneapi/handlers/ssl_cert_storage.go

Line 291 in 1b63b07

rID := h.ReloadAgent.Reload()

I'm happy to provide a Pull Request with the changes needed to add a skip_reload, if there is no obvious reason for this behaviour.

I've found this issue, which talks about similar points: #309

[mjuraga]

It's definetely "no-one made the change yet" situation :). We are more then happy to see your PR.

[fjaeckel]

@mjuraga superduper, I believe the first step is this PR: haproxytech/client-native#116

From here, we can then update dataplaneapi code: #366