Skip to content

GHTeam object missing ways to update some attributes, both singularly and together atomically #2218

@rozza-sb

Description

@rozza-sb

Currently the GHTeam object has some methods to update properties within a team: setDescription and setPrivacy. Not only are these properties not representative of the full list of properties that can be updated; as per the API:

  • name
  • description (already covered)
  • privacy (already covered)
  • notification_setting
  • permission
  • parent_team_id

Additionally, if I wanted to update multiple of these properties at once, they would not be atomic and thus susceptible to network errors messing up an update (or rollback of said update) consisting of multiple properties.

I would like to propose two additional features off of the back of this:

  • Addition of single methods to update the above missing properties on a team, if you only need to change 1 of them
  • Addition of a builder, similar to GHTeamBuilder, that would allow for an atomic update of multiple properties on a team at once

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions