Commit e2289d4
authored
Couple of edge cases in
* Potential read issue.
Reading a single `"0"` could potentially be interpreted as a false response per PHP's truth table, resulting in returning a `null`.
* `fseek()` can fail.
Should `fseek()` fail, we probably want to flag the error.
https://www.libvips.org/API/8.17/vfunc.Source.seek.html#return-value seems to suggest that a `-1` would be appropriate to return in such a case?SourceResource. (#288)1 parent 97bc570 commit e2289d4
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
29 | | - | |
30 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
| |||
0 commit comments