Fix CI (#755)

* Fix CI

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Fix naming

* Ensure naming

* New line fix

---------

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Author: pablogs9

.github/workflows/ci.yml

@@ -46,9 +46,16 @@ jobs:
         run: |
             (test -f install/micro_ros_setup/lib/micro_ros_setup/build_firmware.sh) && true || false
 
+      - name: Sanitize Artifact Name
+        id: sanitize-name
+        run: |
+          sanitized_name=$(echo "${{ inputs.ci_target_ref }}" | sed 's/[\/:*?"<>|\\]/_/g')
+          echo "sanitized_name=$sanitized_name" >> $GITHUB_ENV
+          echo "::set-output name=sanitized_name::$sanitized_name"
+
       - uses: actions/upload-artifact@v4.4.0
         with:
-          name: micro_ros_build_${{ inputs.ci_target_ref }}
+          name: micro_ros_build_${{ steps.sanitize-name.outputs.sanitized_name }}
           path: install
 
   micro_ros_agent:
@@ -79,9 +86,16 @@ jobs:
           rosdep update --rosdistro ${{ env.ROS_DISTRO }}
           rosdep install --rosdistro ${{ env.ROS_DISTRO }} -y --from-paths src --ignore-src -y
 
+      - name: Sanitize Artifact Name
+        id: sanitize-name
+        run: |
+          sanitized_name=$(echo "${{ inputs.ci_target_ref }}" | sed 's/[\/:*?"<>|\\]/_/g')
+          echo "sanitized_name=$sanitized_name" >> $GITHUB_ENV
+          echo "::set-output name=sanitized_name::$sanitized_name"
+
       - uses: actions/download-artifact@v4.1.7
         with:
-          name: micro_ros_build_${{ inputs.ci_target_ref }}
+          name: micro_ros_build_${{ steps.sanitize-name.outputs.sanitized_name }}
           path: install
 
       # Workaround https://github.com/actions/upload-artifact/issues/38
@@ -228,9 +242,16 @@ jobs:
           rosdep update --rosdistro ${{ env.ROS_DISTRO }}
           rosdep install --rosdistro ${{ env.ROS_DISTRO }} -y --from-paths src --ignore-src -y
 
+      - name: Sanitize Artifact Name
+        id: sanitize-name
+        run: |
+          sanitized_name=$(echo "${{ inputs.ci_target_ref }}" | sed 's/[\/:*?"<>|\\]/_/g')
+          echo "sanitized_name=$sanitized_name" >> $GITHUB_ENV
+          echo "::set-output name=sanitized_name::$sanitized_name"
+
       - uses: actions/download-artifact@v4.1.7
         with:
-          name: micro_ros_build_${{ inputs.ci_target_ref }}
+          name: micro_ros_build_${{ steps.sanitize-name.outputs.sanitized_name }}
           path: install
 
       # Workaround https://github.com/actions/upload-artifact/issues/38

config/generate_lib/generic/build.sh

@@ -22,7 +22,7 @@ BUILD_DIR=$FW_TARGETDIR/build
 pushd $FW_TARGETDIR/mcu_ws >/dev/null
 
 	rm -rf build install log
-	
+
    	colcon build \
 		--merge-install \
 		--packages-ignore-regex=.*_cpp \
@@ -48,8 +48,8 @@ pushd $FW_TARGETDIR/mcu_ws >/dev/null
 	done ; \
 	ar rc libmicroros.a $(ls *.o *.obj 2> /dev/null); mkdir -p $BUILD_DIR; cp libmicroros.a $BUILD_DIR; ranlib $BUILD_DIR/libmicroros.a; \
     cp -R $FW_TARGETDIR/mcu_ws/install/include $BUILD_DIR/; \
-    rm $(find $BUILD_DIR/include -type f -not -name "*.h" -not -name "*.hpp") \
-    rm -rf $(find $BUILD_DIR/include -type d -empty) \
+    rm $(find $BUILD_DIR/include -type f -not -name "*.h" -not -name "*.hpp"); \
+    rm -rf $(find $BUILD_DIR/include -type d -empty); \
 	cd ..; rm -rf libmicroros;
 
 popd >/dev/null