Propogate inner exceptions in FailureDetails

andystaples · andystaples · commit d49b3513ffb6 · 2026-01-07T13:24:02.000-07:00
diff --git a/durabletask/internal/helpers.py b/durabletask/internal/helpers.py
@@ -116,11 +116,12 @@ def new_sub_orchestration_failed_event(event_id: int, ex: Exception) -> pb.Histo
     )
 
 
-def new_failure_details(ex: Exception) -> pb.TaskFailureDetails:
+def new_failure_details(ex: BaseException) -> pb.TaskFailureDetails:
     return pb.TaskFailureDetails(
         errorType=type(ex).__name__,
         errorMessage=str(ex),
-        stackTrace=wrappers_pb2.StringValue(value=''.join(traceback.format_tb(ex.__traceback__)))
+        stackTrace=wrappers_pb2.StringValue(value=''.join(traceback.format_tb(ex.__traceback__))),
+        innerFailure=new_failure_details(ex.__cause__) if ex.__cause__ else None
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -116,11 +116,12 @@ def new_sub_orchestration_failed_event(event_id: int, ex: Exception) -> pb.Histo`
`116`	`116`	`)`
`117`	`117`
`118`	`118`
`119`		`-def new_failure_details(ex: Exception) -> pb.TaskFailureDetails:`
	`119`	`+def new_failure_details(ex: BaseException) -> pb.TaskFailureDetails:`
`120`	`120`	`return pb.TaskFailureDetails(`
`121`	`121`	`errorType=type(ex).__name__,`
`122`	`122`	`errorMessage=str(ex),`
`123`		`- stackTrace=wrappers_pb2.StringValue(value=''.join(traceback.format_tb(ex.__traceback__)))`
	`123`	`+ stackTrace=wrappers_pb2.StringValue(value=''.join(traceback.format_tb(ex.__traceback__))),`
	`124`	`+ innerFailure=new_failure_details(ex.__cause__) if ex.__cause__ else None`
`124`	`125`	`)`
`125`	`126`
`126`	`127`