open help center to side on walkthrough (#723)

* open help center to side on walkthrough

Signed-off-by: Yan Zhang <yanzh@microsoft.com>

* remove comments

Signed-off-by: Yan Zhang <yanzh@microsoft.com>

Author: Eskibear

package.json

@@ -164,7 +164,7 @@
           {
             "id": "java.showHelpCenter",
             "title": "Java Help Center",
-            "description": "Discover more shortcuts and features on this page.\n[Open Java Help Center](command:java.welcome)",
+            "description": "Discover more shortcuts and features on this page.\n[Open Java Help Center](command:toSide:java.welcome.fromWalkthrough)",
             "media": {
               "image": "walkthrough/help-center.png",
               "altText": "Java Help Center"
@@ -179,6 +179,11 @@
         "category": "Java",
         "title": "Help Center (Welcome)"
       },
+      {
+        "command": "java.welcome.fromWalkthrough",
+        "category": "Java",
+        "title": "Help Center (Welcome)"
+      },
       {
         "command": "java.classpathConfiguration",
         "category": "Java",
@@ -259,6 +264,10 @@
         {
           "command": "java.formatterSettings.showTextEditor",
           "when": "false"
+        },
+        {
+          "command": "java.welcome.fromWalkthrough",
+          "when": "false"
         }
       ],
       "view/title": [

src/commands/index.ts

@@ -9,7 +9,7 @@ import { javaRuntimeCmdHandler } from "../java-runtime";
 import { javaGettingStartedCmdHandler } from "../getting-started";
 import { javaExtGuideCmdHandler } from "../ext-guide";
 import { instrumentOperationAsVsCodeCommand } from "vscode-extension-telemetry-wrapper";
-import { showWelcomeWebview } from "../welcome";
+import { showWelcomeWebview, showWelcomeWebviewBeside } from "../welcome";
 import { showClasspathConfigurationPage } from "../classpath/classpathConfigurationView";
 import { javaFormatterSettingsEditorProvider } from "../formatter-settings";
 
@@ -27,7 +27,8 @@ export function initialize(context: vscode.ExtensionContext) {
   context.subscriptions.push(vscode.commands.registerCommand("java.gettingStarted", instrumentCommand(context, "java.gettingStarted", javaGettingStartedCmdHandler)));
   context.subscriptions.push(vscode.commands.registerCommand("java.extGuide", instrumentCommand(context, "java.extGuide", javaExtGuideCmdHandler)));
   context.subscriptions.push(instrumentOperationAsVsCodeCommand("java.webview.runCommand", webviewCmdLinkHandler));
-  context.subscriptions.push(vscode.commands.registerCommand("java.welcome", instrumentCommand(context, "java.welcome", showWelcomeWebview)));
+  context.subscriptions.push(vscode.commands.registerCommand("java.welcome", instrumentCommand(context, "java.welcome", showWelcomeWebviewBeside)));
+  context.subscriptions.push(vscode.commands.registerCommand("java.welcome.fromWalkthrough", instrumentCommand(context, "java.welcome.fromWalkthrough", showWelcomeWebview)));
   context.subscriptions.push(vscode.commands.registerCommand("java.formatterSettings", instrumentCommand(context, "java.formatterSettings", () => javaFormatterSettingsEditorProvider.showFormatterSettingsEditor())));
   context.subscriptions.push(vscode.commands.registerCommand("java.formatterSettings.showTextEditor", instrumentCommand(context, "java.formatterSettings.showTextEditor", javaFormatterSettingsEditorProvider.reopenWithTextEditor)));
   context.subscriptions.push(vscode.commands.registerCommand("java.classpathConfiguration", instrumentCommand(context, "java.classpathConfiguration", showClasspathConfigurationPage)));

src/welcome/index.ts

@@ -10,7 +10,18 @@ import { isWalkthroughEnabled } from "../utils/walkthrough";
 
 let welcomeView: vscode.WebviewPanel | undefined;
 
-export async function showWelcomeWebview(context: vscode.ExtensionContext, _operationId?: string, options?: any) {
+// from command palette
+export async function showWelcomeWebviewBeside(context: vscode.ExtensionContext, _operationId?: string, options?: {
+    firstTimeRun?: boolean;
+}) {
+    const newOptions = { openBeside: true, firstTimeRun: options?.firstTimeRun };
+    await showWelcomeWebview(context, _operationId, newOptions);
+}
+
+export async function showWelcomeWebview(context: vscode.ExtensionContext, _operationId?: string, options?: {
+    firstTimeRun?: boolean;
+    openBeside?: boolean;
+}) {
     if (options?.firstTimeRun) {
         setFirstTimeRun(context, true);
     }
@@ -19,10 +30,11 @@ export async function showWelcomeWebview(context: vscode.ExtensionContext, _oper
         welcomeView.reveal();
         fetchInitProps(context);
     } else {
+        const viewColumn = options?.openBeside ? vscode.ViewColumn.Beside : vscode.ViewColumn.Active;
         welcomeView = vscode.window.createWebviewPanel(
             "java.welcome",
             "Java Help Center",
-            vscode.ViewColumn.Beside,
+            viewColumn,
             {
                 enableScripts: true,
                 enableCommandUris: true,