Skip to content

Commit 61db6fc

Browse files
authored
fix: node-addon-api exception handling (#47)
* fix: node-addon-api exception handling * chore: bump version
1 parent c45ebd9 commit 61db6fc

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

binding.gyp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,20 @@
77
"targets": [
88
{
99
"target_name": "vscode-sqlite3",
10-
"cflags!": [ "-fno-exceptions" ],
11-
"cflags_cc!": [ "-fno-exceptions" ],
12-
"xcode_settings": { "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
10+
"xcode_settings": {
1311
"CLANG_CXX_LIBRARY": "libc++",
1412
# Target depends on
1513
# https://chromium.googlesource.com/chromium/src/+/master/build/config/mac/mac_sdk.gni#22
1614
"MACOSX_DEPLOYMENT_TARGET": "10.11",
1715
},
16+
"dependencies": [
17+
"<!(node -p \"require('node-addon-api').targets\"):node_addon_api_except"
18+
],
1819
"msvs_configuration_attributes": {
1920
"SpectreMitigation": "Spectre"
2021
},
2122
"msvs_settings": {
2223
"VCCLCompilerTool": {
23-
"ExceptionHandling": 1,
2424
"AdditionalOptions": [
2525
"/guard:cf",
2626
"/w34244",
@@ -67,7 +67,7 @@
6767
"src/node_sqlite3.cc",
6868
"src/statement.cc"
6969
],
70-
"defines": [ "NAPI_DISABLE_CPP_EXCEPTIONS=1", "NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS" ]
70+
"defines": [ "NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS" ]
7171
},
7272
#{
7373
# "target_name": "action_after_build",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@vscode/sqlite3",
33
"description": "Asynchronous, non-blocking SQLite3 bindings",
4-
"version": "5.1.7-vscode",
4+
"version": "5.1.8-vscode",
55
"homepage": "https://github.com/microsoft/vscode-node-sqlite3",
66
"author": {
77
"name": "Mapbox",

0 commit comments

Comments
 (0)