Skip to content

Commit d77a523

Browse files
authored
Merge pull request #55 from microsoft/rzhao271/4146
5.1.11-vscode
2 parents 16afc9b + 21c1f19 commit d77a523

6 files changed

Lines changed: 2562 additions & 12 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- uses: actions/checkout@v4
1818
with:
1919
persist-credentials: false
20-
- run: yarn install
20+
- run: npm ci
2121
- run: scripts/test-electron.sh
2222
windows:
2323
runs-on: ${{ matrix.os }}
@@ -28,5 +28,5 @@ jobs:
2828
- uses: actions/checkout@v4
2929
with:
3030
persist-credentials: false
31-
- run: yarn install
31+
- run: npm ci
3232
- run: .\scripts\test-electron.bat

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,3 @@ setup.sh
2727
/build-tmp-napi-v3
2828
/build-tmp-napi-v6
2929
*.tgz
30-
package-lock.json
31-
yarn.lock

.yarnrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

binding.gyp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"<!(node -p \"require('node-addon-api').targets\"):node_addon_api_except"
1818
],
1919
"cflags": [
20-
"-O2", "-D_FORTIFY_SOURCE=2"
20+
"-O2"
2121
],
2222
"msvs_configuration_attributes": {
2323
"SpectreMitigation": "Spectre"
@@ -28,8 +28,9 @@
2828
"/guard:cf",
2929
"/sdl",
3030
"/W3",
31-
"/w34244",
32-
"/w34267",
31+
"/we4146",
32+
"/we4244",
33+
"/we4267",
3334
"/ZH:SHA_256"
3435
]
3536
},

0 commit comments

Comments
 (0)