Fix #593#867
Open
neylz wants to merge 1 commit into
Open
Conversation
|
@neylz is attempting to deploy a commit to the misode's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Interesting. Do you not think that the fix should be made in the deepslate library? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593
WebGL defaults to expecting premultiplied alpha, but the shaders output is straight alpha. Firefox's compositor seems to be strict about this mismatch, causing the visual artifacts.
Sets
premultipliedAlphato false to fix that.