Skip to content

Commit b87e373

Browse files
committed
test: use context-managed streams in issue 1561 coverage
1 parent e22de00 commit b87e373

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

tests/issues/test_1561_invalid_method_code.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ async def test_invalid_method_returns_method_not_found() -> None:
1818
read_send_stream, read_receive_stream = anyio.create_memory_object_stream[SessionMessage | Exception](10)
1919
write_send_stream, write_receive_stream = anyio.create_memory_object_stream[SessionMessage](10)
2020

21-
try:
21+
async with read_send_stream, read_receive_stream, write_send_stream, write_receive_stream:
2222
async with ServerSession(
2323
read_stream=read_receive_stream,
2424
write_stream=write_send_stream,
@@ -48,11 +48,6 @@ async def test_invalid_method_returns_method_not_found() -> None:
4848
assert response.id == 1
4949
assert response.error.code == METHOD_NOT_FOUND
5050
assert response.error.message == "Method not found"
51-
finally:
52-
await read_send_stream.aclose()
53-
await write_send_stream.aclose()
54-
await read_receive_stream.aclose()
55-
await write_receive_stream.aclose()
5651

5752

5853
class MissingDefaultMethodRequest(BaseModel):
@@ -71,14 +66,9 @@ async def test_client_session_known_request_methods_match_server_request_union()
7166
read_send_stream, read_receive_stream = anyio.create_memory_object_stream[SessionMessage | Exception](10)
7267
write_send_stream, write_receive_stream = anyio.create_memory_object_stream[SessionMessage](10)
7368

74-
try:
69+
async with read_send_stream, read_receive_stream, write_send_stream, write_receive_stream:
7570
session = ClientSession(read_stream=read_receive_stream, write_stream=write_send_stream)
7671
assert session._known_request_methods == KNOWN_SERVER_REQUEST_METHODS
77-
finally:
78-
await read_send_stream.aclose()
79-
await write_send_stream.aclose()
80-
await read_receive_stream.aclose()
81-
await write_receive_stream.aclose()
8272

8373

8474
class DummyBaseSession(
@@ -104,13 +94,8 @@ async def test_base_session_known_request_methods_default_to_empty() -> None:
10494
read_send_stream, read_receive_stream = anyio.create_memory_object_stream[SessionMessage | Exception](10)
10595
write_send_stream, write_receive_stream = anyio.create_memory_object_stream[SessionMessage](10)
10696

107-
try:
97+
async with read_send_stream, read_receive_stream, write_send_stream, write_receive_stream:
10898
session = DummyBaseSession(read_stream=read_receive_stream, write_stream=write_send_stream)
10999
assert session._known_request_methods == frozenset()
110100
assert session._receive_request_adapter is types.server_request_adapter
111101
assert session._receive_notification_adapter is types.server_notification_adapter
112-
finally:
113-
await read_send_stream.aclose()
114-
await write_send_stream.aclose()
115-
await read_receive_stream.aclose()
116-
await write_receive_stream.aclose()

0 commit comments

Comments
 (0)