test(migrations): add SQLite guard, move assertions before upgrade restore (#2)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: nanotaboada

CHANGELOG.md

@@ -57,7 +57,9 @@ This project uses famous football coaches as release codenames, following an A-Z
   before any workers are forked, replacing the entrypoint-driven migration
   pattern (#2)
 - `tests/test_migrations.py`: integration tests for migration downgrade paths —
-  verifies each step removes only its seeded rows and restores correctly (#2)
+  verifies each step removes only its seeded rows and restores correctly; guarded
+  with `pytestmark` skip for non-SQLite databases; assertions moved before
+  `upgrade head` restore step for clarity (#2)
 - `tests/conftest.py`: session-scoped `apply_migrations` fixture runs
   `alembic upgrade head` once before the test session, ensuring the database
   exists and is at head in CI and local environments (#2)

tests/test_migrations.py

@@ -9,15 +9,24 @@
 or more steps, asserts the expected state, then restores to head before the
 next test, ensuring the shared SQLite database remains consistent for any
 subsequent test runs.
+
+These tests are SQLite-only: they open the database file directly via
+sqlite3.connect() to inspect raw state, which is not possible with PostgreSQL.
 """
 
 import sqlite3
 
+import pytest
 from alembic import command
 
 from databases.player_database import DATABASE_URL
 from tests.conftest import ALEMBIC_CONFIG
 
+pytestmark = pytest.mark.skipif(
+    not DATABASE_URL.startswith("sqlite"),
+    reason="Migration downgrade tests require SQLite",
+)
+
 DB_PATH = DATABASE_URL.replace("sqlite+aiosqlite:///", "")
 
 
@@ -30,11 +39,11 @@ def test_migration_downgrade_003_removes_substitutes_only():
     subs = conn.execute("SELECT COUNT(*) FROM players WHERE starting11=0").fetchone()[0]
     conn.close()
 
-    command.upgrade(ALEMBIC_CONFIG, "head")
-
     assert total == 11
     assert subs == 0
 
+    command.upgrade(ALEMBIC_CONFIG, "head")
+
 
 def test_migration_downgrade_002_removes_starting11_only():
     """Downgrade 002→001 removes the 11 seeded Starting XI, leaves table empty."""
@@ -44,10 +53,10 @@ def test_migration_downgrade_002_removes_starting11_only():
     total = conn.execute("SELECT COUNT(*) FROM players").fetchone()[0]
     conn.close()
 
-    command.upgrade(ALEMBIC_CONFIG, "head")
-
     assert total == 0
 
+    command.upgrade(ALEMBIC_CONFIG, "head")
+
 
 def test_migration_downgrade_001_drops_players_table():
     """Downgrade 001→base drops the players table entirely."""
@@ -59,6 +68,6 @@ def test_migration_downgrade_001_drops_players_table():
     ).fetchone()
     conn.close()
 
-    command.upgrade(ALEMBIC_CONFIG, "head")
-
     assert table is None
+
+    command.upgrade(ALEMBIC_CONFIG, "head")