fix(theming): read cachebuster as int in manifest endpoint#61007
Merged
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
CarlSchwan
approved these changes
Jun 5, 2026
artonge
approved these changes
Jun 5, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/61007/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17bbc56d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61007/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/61007/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17bbc56d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61007/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The theming/cachebuster app config value is declared as
ValueType::INTin the config lexicon, stored as INT, and written/read as INT everywhere (ImageManager, ThemingDefaults).ThemingController::getManifest()was theonly place reading it via
getAppValueString(), which requests VALUE_STRING and conflicts with the stored VALUE_INT, throwing AppConfigTypeConflictException on every manifest requestRegression introduced in #60198
Checklist
3. to review, feature component)stable32)AI (if applicable)