Skip to content

fix(theming): read cachebuster as int in manifest endpoint#61007

Merged
skjnldsv merged 1 commit into
masterfrom
fix/theming-cachebuster-type-conflict
Jun 5, 2026
Merged

fix(theming): read cachebuster as int in manifest endpoint#61007
skjnldsv merged 1 commit into
masterfrom
fix/theming-cachebuster-type-conflict

Conversation

@solracsf
Copy link
Copy Markdown
Member

@solracsf solracsf commented Jun 5, 2026

Summary

The theming/cachebuster app config value is declared as ValueType::INT in the config lexicon, stored as INT, and written/read as INT everywhere (ImageManager, ThemingDefaults). ThemingController::getManifest() was the
only place reading it via getAppValueString(), which requests VALUE_STRING and conflicts with the stored VALUE_INT, throwing AppConfigTypeConflictException on every manifest request

Regression introduced in #60198

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added this to the Nextcloud 35 milestone Jun 5, 2026
@solracsf solracsf requested a review from a team as a code owner June 5, 2026 08:38
@solracsf solracsf requested review from artonge, leftybournes, provokateurin and salmart-dev and removed request for a team June 5, 2026 08:38
@solracsf
Copy link
Copy Markdown
Member Author

solracsf commented Jun 5, 2026

/backport to stable34

@solracsf
Copy link
Copy Markdown
Member Author

solracsf commented Jun 5, 2026

/backport to stable33

@solracsf
Copy link
Copy Markdown
Member Author

solracsf commented Jun 5, 2026

/backport to stable32

@skjnldsv skjnldsv merged commit d44790d into master Jun 5, 2026
167 of 180 checks passed
@skjnldsv skjnldsv deleted the fix/theming-cachebuster-type-conflict branch June 5, 2026 09:48
@backportbot
Copy link
Copy Markdown

backportbot Bot commented Jun 5, 2026

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/61007/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17bbc56d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61007/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@solracsf
Copy link
Copy Markdown
Member Author

solracsf commented Jun 5, 2026

/backport to stable33

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Jun 5, 2026

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/61007/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17bbc56d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61007/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: conflict with value type from database AppConfigTypeConflictException conflict with value type from database

4 participants