From 455dab6a3859e19439c9258c56a5f113047c0e50 Mon Sep 17 00:00:00 2001 From: aryanpingle Date: Sun, 17 May 2026 14:20:37 +0530 Subject: [PATCH 1/3] feat: set cursor-pointer on ButtonBase --- CONTRIBUTING.md | 2 +- app/components/Button/Base.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 74f9d19243..254c6385b7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -452,7 +452,7 @@ The command palette is a first-class navigation surface. When you add a new user ### Cursor and navigation -**npmx** uses `cursor: pointer` only for links to match users’ everyday experience. For all other interactive elements, including buttons, use the default cursor (_or another appropriate cursor to indicate state_). +**npmx** uses `cursor: pointer` for links and buttons to match users’ everyday experience. For all other interactive elements, use the default cursor (_or another appropriate cursor to indicate state_). > [!NOTE] > A link is any element that leads to another content (_go to another page, authorize_) diff --git a/app/components/Button/Base.vue b/app/components/Button/Base.vue index 1a142b193f..48997ac550 100644 --- a/app/components/Button/Base.vue +++ b/app/components/Button/Base.vue @@ -44,7 +44,7 @@ defineExpose({ @@ -44,7 +48,11 @@ onPrehydrate(el => { {{ $t('search.instant_search_off') }} From 791a6dbba729cd1391e444d76bf438739cd1f071 Mon Sep 17 00:00:00 2001 From: aryanpingle Date: Sun, 17 May 2026 14:46:32 +0530 Subject: [PATCH 3/3] feat: set cursor-pointer for chart elements --- app/components/Compare/FacetBarChart.vue | 1 + app/components/Compare/FacetScatterChart.vue | 1 + app/components/Package/TimelineChart.vue | 1 + app/components/Package/TrendsChart.vue | 1 + app/components/Package/VersionDistribution.vue | 1 + 5 files changed, 5 insertions(+) diff --git a/app/components/Compare/FacetBarChart.vue b/app/components/Compare/FacetBarChart.vue index f8393c14b0..ae6ab4886a 100644 --- a/app/components/Compare/FacetBarChart.vue +++ b/app/components/Compare/FacetBarChart.vue @@ -152,6 +152,7 @@ const config = computed(() => { }) }, }, + useCursorPointer: true, }, skeletonDataset: skeletonDataset.value, skeletonConfig: { diff --git a/app/components/Compare/FacetScatterChart.vue b/app/components/Compare/FacetScatterChart.vue index 2d5442c3e0..34482360f8 100644 --- a/app/components/Compare/FacetScatterChart.vue +++ b/app/components/Compare/FacetScatterChart.vue @@ -166,6 +166,7 @@ const config = computed(() => { }) }, }, + useCursorPointer: true, }, style: { backgroundColor: colors.value.bg, diff --git a/app/components/Package/TimelineChart.vue b/app/components/Package/TimelineChart.vue index 87e600e86d..bc783bca74 100644 --- a/app/components/Package/TimelineChart.vue +++ b/app/components/Package/TimelineChart.vue @@ -411,6 +411,7 @@ const config = computed(() => { }, }), }, + useCursorPointer: true, }, zoom: { show: settings.value.timelineChart.showZoom, diff --git a/app/components/Package/TrendsChart.vue b/app/components/Package/TrendsChart.vue index 2185d9d9b6..8f4e189419 100644 --- a/app/components/Package/TrendsChart.vue +++ b/app/components/Package/TrendsChart.vue @@ -1460,6 +1460,7 @@ const chartConfig = computed(() => { }, }), }, + useCursorPointer: true, }, grid: { position: 'start', diff --git a/app/components/Package/VersionDistribution.vue b/app/components/Package/VersionDistribution.vue index 950dd38f29..9565ab6962 100644 --- a/app/components/Package/VersionDistribution.vue +++ b/app/components/Package/VersionDistribution.vue @@ -238,6 +238,7 @@ const chartConfig = computed(() => { }, }), }, + useCursorPointer: true, }, grid: { stroke: colors.value.border,