Skip to content

Commit 28d9588

Browse files
feat: make PROXY_ROLE_ASSIGNMENT_DRIVER configurable
Allow PROXY_ROLE_ASSIGNMENT_DRIVER to be set via environment variable in .env file, with oidc remaining as the default value. I was frustrated that this was hard coded since my OIDC doesn't offer the complete scope, so I made it configurable.
1 parent 59f5f17 commit 28d9588

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

.env.example

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,9 @@ LDAP_BIND_PASSWORD=
298298

299299
## Autoprovisioning Mode ##
300300
# Use together with idm/external-idp.yml
301+
# Role assignment driver for the proxy. Defaults to "oidc".
302+
# Possible values: "oidc", "default"
303+
PROXY_ROLE_ASSIGNMENT_DRIVER=
301304
# If you want to use a keycloak for local testing, you can use testing/external-keycloak.yml and testing/ldap-manager.yml
302305
# Domain of your Identity Provider.
303306
IDP_DOMAIN=

idm/external-idp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ services:
1515
FRONTEND_READONLY_USER_ATTRIBUTES: "user.onPremisesSamAccountName,user.displayName,user.mail,user.passwordProfile,user.accountEnabled,user.appRoleAssignments"
1616
PROXY_OIDC_REWRITE_WELLKNOWN: "true"
1717
WEB_OIDC_CLIENT_ID: ${OC_OIDC_CLIENT_ID:-web}
18-
PROXY_ROLE_ASSIGNMENT_DRIVER: "oidc"
18+
PROXY_ROLE_ASSIGNMENT_DRIVER: ${PROXY_ROLE_ASSIGNMENT_DRIVER:-oidc}
1919
OC_OIDC_ISSUER: ${IDP_ISSUER_URL:-https://keycloak.opencloud.test/realms/openCloud}
2020
# This specifies to start all services except idm and idp. These are replaced by external services.
2121
OC_EXCLUDE_RUN_SERVICES: idm,idp

0 commit comments

Comments
 (0)