fix: withdrawal notifications broken — dead import silently swallowed

The withdraw_submission view imported the removed legacy function
_notify_workflow_notification_with_cadence from workflow_engine. A bare
'except Exception' silently swallowed the ImportError, so form_withdrawn
notification rules never fired for any form.

Replace with _dispatch_notification_rules(submission, 'form_withdrawn')
which is the unified notification dispatch used by all other events.

Bump version to 0.61.1.

Author: matteius

CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.61.1] - 2026-04-02
+
+### Fixed
+- **Withdrawal notifications broken** — `withdraw_submission` view imported the
+  removed legacy function `_notify_workflow_notification_with_cadence`; a bare
+  `except Exception` silently swallowed the `ImportError`, so `form_withdrawn`
+  notification rules never fired for any form. Replaced with a direct call to
+  `_dispatch_notification_rules(submission, "form_withdrawn")`.
+
 ## [0.61.0] - 2026-04-02
 
 ### Added

django_forms_workflows/views.py

@@ -2235,18 +2235,10 @@ def withdraw_submission(request, submission_id):
             comments="Submission withdrawn by submitter",
         )
 
-        # Send withdrawal notifications — respects notification_cadence.
-        try:
-            from .workflow_engine import _notify_workflow_notification_with_cadence
+        # Dispatch form_withdrawn notification rules.
+        from .workflow_engine import _dispatch_notification_rules
 
-            _notify_workflow_notification_with_cadence(
-                submission, "withdrawal_notification"
-            )
-        except Exception:
-            logger.warning(
-                "Could not dispatch withdrawal notifications for submission %s",
-                submission.id,
-            )
+        _dispatch_notification_rules(submission, "form_withdrawn")
 
         messages.success(request, "Submission withdrawn successfully.")
         return redirect("forms_workflows:my_submissions")

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-forms-workflows"
-version = "0.61.0"
+version = "0.61.1"
 description = "Enterprise-grade, database-driven form builder with approval workflows and external data integration"
 license = "LGPL-3.0-only"
 readme = "README.md"

tests/test_views.py

@@ -3,6 +3,7 @@
 """
 
 from datetime import timedelta
+from unittest import mock
 
 import pytest
 from django.test import Client
@@ -170,6 +171,25 @@ def test_cannot_withdraw_approved(self, auth_client, form_with_fields, user):
         sub.refresh_from_db()
         assert sub.status == "approved"  # Should not change
 
+    def test_withdraw_dispatches_form_withdrawn_notification(
+        self, auth_client, form_with_fields, user
+    ):
+        """Withdrawal must call _dispatch_notification_rules with 'form_withdrawn'."""
+        sub = FormSubmission.objects.create(
+            form_definition=form_with_fields,
+            submitter=user,
+            form_data={"full_name": "Test"},
+            status="pending_approval",
+        )
+        url = reverse("forms_workflows:withdraw_submission", args=[sub.pk])
+        with mock.patch(
+            "django_forms_workflows.workflow_engine._dispatch_notification_rules"
+        ) as mock_dispatch:
+            auth_client.post(url)
+        mock_dispatch.assert_called_once_with(mock.ANY, "form_withdrawn")
+        # Verify it was called with the right submission
+        assert mock_dispatch.call_args[0][0].id == sub.id
+
 
 # ── submission_detail ────────────────────────────────────────────────────