wip

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/EventFilterDetails.java

@@ -41,7 +41,7 @@ public void setLastEvent(ResourceEvent event) {
   public Optional<ResourceEvent> getLatestEventAfterLastUpdateEvent(String updatedResourceVersion) {
     if (lastEvent != null
         && (updatedResourceVersion == null
-            || ReconcileUtils.validateAndCompareResourceVersions(
+            || ReconcileUtils.compareResourceVersions(
                     lastEvent.getResource().orElseThrow().getMetadata().getResourceVersion(),
                     updatedResourceVersion)
                 > 0)) {

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java

@@ -174,10 +174,7 @@ public Optional<R> get(ResourceID resourceID) {
     Optional<R> resource = temporaryResourceCache.getResourceFromCache(resourceID);
     if (comparableResourceVersions
         && resource.isPresent()
-        && res.filter(
-                r ->
-                    ReconcileUtils.validateAndCompareResourceVersions(r, resource.orElseThrow())
-                        > 0)
+        && res.filter(r -> ReconcileUtils.compareResourceVersions(r, resource.orElseThrow()) > 0)
             .isEmpty()) {
       log.debug("Latest resource found in temporary cache for Resource ID: {}", resourceID);
       return resource;

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCache.java

@@ -123,7 +123,7 @@ private synchronized EventHandling onEvent(T resource, boolean unknownState, boo
     EventHandling result = EventHandling.NEW;
     int comp = 0;
     if (cached != null) {
-      comp = ReconcileUtils.validateAndCompareResourceVersions(resource, cached);
+      comp = ReconcileUtils.compareResourceVersions(resource, cached);
       if (comp >= 0 || unknownState) {
         cache.remove(resourceId);
         // we propagate event only for our update or newer other can be discarded since we know we
@@ -185,7 +185,7 @@ public synchronized void putResource(T newResource) {
     var cachedResource = getResourceFromCache(resourceId).orElse(null);
 
     if (cachedResource == null
-        || ReconcileUtils.validateAndCompareResourceVersions(newResource, cachedResource) > 0) {
+        || ReconcileUtils.compareResourceVersions(newResource, cachedResource) > 0) {
       log.debug(
           "Temporarily moving ahead to target version {} for resource id: {}",
           newResource.getMetadata().getResourceVersion(),