Skip to content
This repository was archived by the owner on Oct 29, 2021. It is now read-only.

Commit 3794050

Browse files
author
Luka Jacobowitz
committed
rename Sink.createSink to Sink.create
1 parent ecaf7f2 commit 3794050

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

src/Sink.purs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ foreign import createHandlerImpl :: forall a e. Array a -> Handler e a
2626
createHandler :: forall a e. Array a -> Handler e a
2727
createHandler = createHandlerImpl
2828

29-
createSink :: forall a e. (a -> Eff e Unit) -> Sink e a
30-
createSink fn = { sink : Observer fn }
29+
create :: forall a e. (a -> Eff e Unit) -> Sink e a
30+
create fn = { sink : Observer fn }
3131

3232

3333
foreign import redirect :: forall a b e r. SinkLike e a r -> (Observable b -> Observable a) -> Sink e b

src/util/Store.purs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type Store eff state action =
1313

1414
createStore :: forall eff state action. state -> (action -> state -> state) -> Store eff state action
1515
createStore initialState reducer =
16-
let handler = createHandler []
16+
let handler = createHandler[]
1717
src = handler.src
1818
# scan reducer initialState
1919
# startWith initialState

test/DomEventSpec.purs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import DOM.Node.ParentNode (childElementCount, querySelector)
2121
import DOM.Node.Types (Document, Node, documentToParentNode, elementToEventTarget, elementToNode)
2222
import Data.Array (length) as Array
2323
import EmitterBuilder (mapE, override)
24-
import OutWatch.Sink (createSink)
24+
import OutWatch.Sink (create)
2525
import Prelude (Unit, bind, const, map, not, pure, show, (#), ($), (==))
2626
import RxJS.Observable (fromArray, just)
2727
import Test.JsHelpers (newEvent)
@@ -60,7 +60,7 @@ domEventSuite =
6060
test "The DOM Events Api should be able to emit events to a Sink" do
6161
refFlag <- liftEff (newRef false)
6262
liftEff createDomRoot
63-
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
63+
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
6464
root = div [ click ==> sink ]
6565
flagBeforeAll <- liftEff (readRef refFlag)
6666
assert "Emitter shouldn't emit before rendering" (not flagBeforeAll)
@@ -79,8 +79,8 @@ domEventSuite =
7979
refFlag <- liftEff (newRef false)
8080
refFlag2 <- liftEff (newRef false)
8181
liftEff createDomRoot
82-
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
83-
sink2 = createSink (\_ -> modifyRef refFlag2 (\_ -> true))
82+
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
83+
sink2 = create (\_ -> modifyRef refFlag2 (\_ -> true))
8484
root = div [ click ==> sink , click ==> sink2 ]
8585
liftEff (render "#app" root)
8686
doc <- liftEff getDocument
@@ -96,7 +96,7 @@ domEventSuite =
9696
test "Event emitters should be able to have their values mapped" do
9797
refFlag <- liftEff (newRef false)
9898
liftEff createDomRoot
99-
let sink = createSink (\b -> modifyRef refFlag (\_ -> b))
99+
let sink = create (\b -> modifyRef refFlag (\_ -> b))
100100
root = div [ mapE click (const true) ==> sink ]
101101
liftEff (render "#app" root)
102102
doc <- liftEff getDocument
@@ -110,7 +110,7 @@ domEventSuite =
110110
test "Event emitters should be able to have their values overriden by another Observable" do
111111
refFlag <- liftEff (newRef false)
112112
liftEff createDomRoot
113-
let sink = createSink (\b -> modifyRef refFlag (\_ -> b))
113+
let sink = create (\b -> modifyRef refFlag (\_ -> b))
114114
stream = just true
115115
root = div [ override click stream ==> sink ]
116116
liftEff (render "#app" root)

test/LifecycleHookSpec.purs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import DOM.Node.Element (setAttribute)
1818
import DOM.Node.Node (appendChild, setTextContent)
1919
import DOM.Node.Types (Node, elementToNode)
2020
import Data.Unit (Unit)
21-
import OutWatch.Sink (createSink)
21+
import OutWatch.Sink (create)
2222
import Prelude (bind, not)
2323
import RxJS.Observable (fromArray)
2424
import Test.Unit (TestSuite, suite, test)
@@ -34,7 +34,7 @@ lifecycleHookSuite =
3434
test "insertion hooks should be called when a VNode is inserted" do
3535
refFlag <- liftEff (newRef false)
3636
liftEff createDomRoot
37-
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
37+
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
3838
root = div [ insert ==> sink ]
3939
flagBeforeRendering <- liftEff (readRef refFlag)
4040
assert "Insert hook shouldn't be called before rendering" (not flagBeforeRendering)
@@ -45,7 +45,7 @@ lifecycleHookSuite =
4545
test "destruction hooks should be called when a VNode is destroyed" do
4646
refFlag <- liftEff (newRef false)
4747
liftEff createDomRoot
48-
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
48+
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
4949
innerChild = fromArray [ span [ destroy ==> sink ], h3 [] ]
5050
root = div [ child <== innerChild ]
5151
flagBeforeRendering <- liftEff (readRef refFlag)
@@ -57,7 +57,7 @@ lifecycleHookSuite =
5757
test "update hooks should be called when a VNode is updated" do
5858
refFlag <- liftEff (newRef false)
5959
liftEff createDomRoot
60-
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
60+
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
6161
innerChild = fromArray [ span [ update ==> sink, text "First" ], span [ update ==> sink , text "second" ] ]
6262
root = div [ child <== innerChild ]
6363
flagBeforeRendering <- liftEff (readRef refFlag)

0 commit comments

Comments
 (0)