fix: do not drop functions in the upgrade migration

Fixes #258

Author: palkan

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## master (unreleased)
 
+- Don't drop functions in the upgrade migration. ([@palkan][])
+
 ## 1.4.0 (2025-05-09) 🎇
 
 - Support Rails 7.2 ([@atomaka][])

lib/generators/logidze/install/templates/migration.rb.erb

@@ -1,19 +1,5 @@
 class <%= @migration_class_name %> < ActiveRecord::Migration[<%= ActiveRecord::Migration.current_version %>]
   def up
-<%- if update? -%>
-    # Drop legacy functions (<1.0)
-    execute <<~SQL
-      DROP FUNCTION IF EXISTS logidze_version(bigint, jsonb);
-      DROP FUNCTION IF EXISTS logidze_snapshot(jsonb);
-      DROP FUNCTION IF EXISTS logidze_version(bigint, jsonb, text[]);
-      DROP FUNCTION IF EXISTS logidze_snapshot(jsonb, text[]);
-      DROP FUNCTION IF EXISTS logidze_version(bigint, jsonb, timestamp with time zone, text[]);
-      DROP FUNCTION IF EXISTS logidze_snapshot(jsonb, text, text[]);
-      DROP FUNCTION IF EXISTS logidze_exclude_keys(jsonb, VARIADIC text[]);
-      DROP FUNCTION IF EXISTS logidze_compact_history(jsonb);
-    SQL
-
-<%- end -%>
     execute <<~SQL
 <%- function_definitions.each do |f| -%>
 <%= inject_sql("#{f.name}.sql", indent: 6) %>

lib/generators/logidze/install/templates/migration_fx.rb.erb

@@ -1,41 +1,22 @@
 class <%= @migration_class_name %> < ActiveRecord::Migration[<%= ActiveRecord::Migration.current_version %>]
   def change
-  <%- if update? -%>
-    reversible do |dir|
-      dir.up do
-        # Drop legacy functions (<1.0)
-        execute <<~SQL
-          DROP FUNCTION IF EXISTS logidze_version(bigint, jsonb);
-          DROP FUNCTION IF EXISTS logidze_snapshot(jsonb);
-          DROP FUNCTION IF EXISTS logidze_version(bigint, jsonb, text[]);
-          DROP FUNCTION IF EXISTS logidze_snapshot(jsonb, text[]);
-          DROP FUNCTION IF EXISTS logidze_version(bigint, jsonb, timestamp with time zone, text[]);
-          DROP FUNCTION IF EXISTS logidze_snapshot(jsonb, text, text[]);
-          DROP FUNCTION IF EXISTS logidze_exclude_keys(jsonb, VARIADIC text[]);
-          DROP FUNCTION IF EXISTS logidze_compact_history(jsonb);
-        SQL
-      end
-    end
-
-  <%- end -%>
   <%- function_definitions.each do |f| -%>
     <%- previous_version = previous_version_for(f.name) -%>
     <%- if previous_version -%>
       <%- if previous_version != f.version -%>
-    update_function :<%= f.name %>, version: <%= f.version %>, revert_to_version: <%= previous_version %>
-      <%- end -%>
-    <%- else -%>
     reversible do |dir|
       dir.up do
         create_function :<%= f.name %>, version: <%= f.version %>
       end
 
       dir.down do
-        execute "DROP FUNCTION IF EXISTS <%= f.name %>(<%= f.signature %>) CASCADE"
+        create_function :<%= f.name %>, version: <%= previous_version %>
       end
     end
-
-    <%- end -%>
+      <%- end %>
+    <%- else -%>
+    create_function :<%= f.name %>, version: <%= f.version %>
+    <%- end %>
   <%- end -%>
   end
 end

spec/generators/install_generator_spec.rb

@@ -49,14 +49,6 @@
         is_expected.to contain("create_function :logidze_filter_keys, version: 1")
         is_expected.to contain("create_function :logidze_compact_history, version: 1")
         is_expected.to contain("create_function :logidze_capture_exception, version: 1")
-
-        is_expected.to contain("DROP FUNCTION IF EXISTS logidze_logger")
-        is_expected.to contain("DROP FUNCTION IF EXISTS logidze_logger_after")
-        is_expected.to contain("DROP FUNCTION IF EXISTS logidze_snapshot")
-        is_expected.to contain("DROP FUNCTION IF EXISTS logidze_version")
-        is_expected.to contain("DROP FUNCTION IF EXISTS logidze_filter_keys")
-        is_expected.to contain("DROP FUNCTION IF EXISTS logidze_compact_history")
-        is_expected.to contain("DROP FUNCTION IF EXISTS logidze_capture_exception")
       end
 
       it "creates function files" do
@@ -145,12 +137,21 @@
         run_generator(args)
 
         is_expected.to be_a_file
-        is_expected.to contain("update_function :logidze_version, version: 2, revert_to_version: 3")
-        is_expected.to contain("update_function :logidze_snapshot, version: 3, revert_to_version: 4")
-        is_expected.not_to contain("update_function :logidze_filter_keys")
-        is_expected.to contain("update_function :logidze_compact_history, version: 1, revert_to_version: 5")
-        is_expected.to contain("update_function :logidze_logger, version: 5, revert_to_version: 7")
-        is_expected.to contain("update_function :logidze_logger_after, version: 5, revert_to_version: 7")
+        is_expected.to contain("create_function :logidze_version, version: 2")
+        is_expected.to contain("create_function :logidze_version, version: 3")
+
+        is_expected.to contain("create_function :logidze_snapshot, version: 3")
+        is_expected.to contain("create_function :logidze_snapshot, version: 4")
+
+        is_expected.not_to contain("create_function :logidze_filter_keys")
+        is_expected.to contain("create_function :logidze_compact_history, version: 1")
+
+        is_expected.to contain("create_function :logidze_logger, version: 5")
+        is_expected.to contain("create_function :logidze_logger, version: 7")
+
+        is_expected.to contain("create_function :logidze_logger_after, version: 5")
+        is_expected.to contain("create_function :logidze_logger_after, version: 7")
+
         is_expected.to contain("create_function :logidze_capture_exception")
       end