Removed dimensions check from SQLAlchemy for consistency with built-in types

Author: ankane

pgvector/halfvec.py

@@ -71,16 +71,13 @@ def from_binary(cls, value: bytes) -> HalfVector:
         return vec
 
     @classmethod
-    def _to_db(cls, value: object, dim: int | None = None) -> str | None:
+    def _to_db(cls, value: object) -> str | None:
         if value is None:
             return value
 
         if not isinstance(value, cls):
             value = cls(value)  # ty: ignore[invalid-argument-type]
 
-        if dim is not None and value.dimensions() != dim:
-            raise ValueError('expected %d dimensions, not %d' % (dim, value.dimensions()))
-
         return value.to_text()
 
     @classmethod

pgvector/sparsevec.py

@@ -149,16 +149,13 @@ def _from_parts(cls, dim: int, indices: list[int], values: list[float]) -> Spars
         return vec
 
     @classmethod
-    def _to_db(cls, value: object, dim: int | None = None) -> str | None:
+    def _to_db(cls, value: object) -> str | None:
         if value is None:
             return value
 
         if not isinstance(value, cls):
             value = cls(value)
 
-        if dim is not None and value.dimensions() != dim:
-            raise ValueError('expected %d dimensions, not %d' % (dim, value.dimensions()))
-
         return value.to_text()
 
     @classmethod

pgvector/sqlalchemy/halfvec.py

@@ -20,14 +20,14 @@ def get_col_spec(self, **kw: Any) -> str:
 
     def bind_processor(self, dialect: Dialect) -> Any:
         def process(value: Any) -> str | None:
-            return HalfVector._to_db(value, self.dim)
+            return HalfVector._to_db(value)
         return process
 
     def literal_processor(self, dialect: Dialect) -> Any:
         string_literal_processor = self._string._cached_literal_processor(dialect)
 
         def process(value: Any) -> Any:
-            return string_literal_processor(HalfVector._to_db(value, self.dim))  # type: ignore
+            return string_literal_processor(HalfVector._to_db(value))  # type: ignore
         return process
 
     def result_processor(self, dialect: Dialect, coltype: Any) -> Any:

pgvector/sqlalchemy/sparsevec.py

@@ -20,14 +20,14 @@ def get_col_spec(self, **kw: Any) -> str:
 
     def bind_processor(self, dialect: Dialect) -> Any:
         def process(value: Any) -> str | None:
-            return SparseVector._to_db(value, self.dim)
+            return SparseVector._to_db(value)
         return process
 
     def literal_processor(self, dialect: Dialect) -> Any:
         string_literal_processor = self._string._cached_literal_processor(dialect)
 
         def process(value: Any) -> Any:
-            return string_literal_processor(SparseVector._to_db(value, self.dim))  # type: ignore
+            return string_literal_processor(SparseVector._to_db(value))  # type: ignore
         return process
 
     def result_processor(self, dialect: Dialect, coltype: Any) -> Any:

pgvector/sqlalchemy/vector.py

@@ -20,14 +20,14 @@ def get_col_spec(self, **kw: Any) -> str:
 
     def bind_processor(self, dialect: Dialect) -> Any:
         def process(value: Any) -> str | None:
-            return Vector._to_db(value, self.dim)
+            return Vector._to_db(value)
         return process
 
     def literal_processor(self, dialect: Dialect) -> Any:
         string_literal_processor = self._string._cached_literal_processor(dialect)
 
         def process(value: Any) -> Any:
-            return string_literal_processor(Vector._to_db(value, self.dim))  # type: ignore
+            return string_literal_processor(Vector._to_db(value))  # type: ignore
         return process
 
     def result_processor(self, dialect: Dialect, coltype: Any) -> Any:

pgvector/vector.py

@@ -71,16 +71,13 @@ def from_binary(cls, value: bytes) -> Vector:
         return vec
 
     @classmethod
-    def _to_db(cls, value: object, dim: int | None = None) -> str | None:
+    def _to_db(cls, value: object) -> str | None:
         if value is None:
             return value
 
         if not isinstance(value, cls):
             value = cls(value)  # ty: ignore[invalid-argument-type]
 
-        if dim is not None and value.dimensions() != dim:
-            raise ValueError('expected %d dimensions, not %d' % (dim, value.dimensions()))
-
         return value.to_text()
 
     @classmethod