gen_stub: various simplifications and clean up (6)#19699
Merged
DanielEScherzer merged 5 commits intophp:masterfrom Mar 16, 2026
Merged
gen_stub: various simplifications and clean up (6)#19699DanielEScherzer merged 5 commits intophp:masterfrom
DanielEScherzer merged 5 commits intophp:masterfrom
Conversation
kocsismate
reviewed
Sep 27, 2025
kocsismate
reviewed
Sep 27, 2025
Member
kocsismate
left a comment
kocsismate
left a comment
There was a problem hiding this comment.
LGTM except for my nit and Arnaud's comment
DanielEScherzer
force-pushed
the
stub-simplify-6
branch
2 times, most recently
from
b9b4c1b to
37bddab
Compare
Member
Author
kocsismate
approved these changes
Mar 16, 2026
arnaud-lb
approved these changes
Mar 16, 2026
Reduce the number of global functions by moving it to instance method `FileInfo::generateArgInfoCode()`. In the process, make the following parts of `FileInfo` private: - `$funcInfos` - `$generateFunctionEntries` - `$declarationPrefix` - `$generateClassEntries` - `$generateCEnums` - `::getMinimumPhpVersionIdCompatibility()`
DanielEScherzer
force-pushed
the
stub-simplify-6
branch
from
37bddab to
25f62cf
Compare
Member
Author
|
(Rebased so that I could merge commits while still having them be signed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit can be reviewed independently, and should have no functional changes