Remove Reflector from StubFilesExtensionLoader, add regression test

Replace the expensive `reflectClass('...ServiceEntityRepository')` call with a
cheap `InstalledVersions::getVersion('doctrine/doctrine-bundle')` + `version_compare`
check. LazyServiceEntityRepository became ServiceEntityRepository's parent in
DoctrineBundle 2.8.1, so the version threshold is exact.

Add StubFilesExtensionLoaderTest with ThrowingSourceLocator registered as
`betterReflectionSourceLocator` in the test container — any future attempt to
re-introduce reflectClass() in getFiles() will immediately throw.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: xificurk

src/Stubs/Doctrine/StubFilesExtensionLoader.php

@@ -4,25 +4,15 @@
 
 use Composer\InstalledVersions;
 use OutOfBoundsException;
-use PHPStan\BetterReflection\Reflector\Exception\IdentifierNotFound;
-use PHPStan\BetterReflection\Reflector\Reflector;
 use PHPStan\PhpDoc\StubFilesExtension;
 use function class_exists;
 use function dirname;
 use function strpos;
+use function version_compare;
 
 class StubFilesExtensionLoader implements StubFilesExtension
 {
 
-	private Reflector $reflector;
-
-	public function __construct(
-		Reflector $reflector
-	)
-	{
-		$this->reflector = $reflector;
-	}
-
 	public function getFiles(): array
 	{
 		$stubsDir = dirname(dirname(dirname(__DIR__))) . '/stubs';
@@ -36,20 +26,7 @@ public function getFiles(): array
 			$files[] = $stubsDir . '/DBAL/Connection.stub';
 		}
 
-		$hasLazyServiceEntityRepositoryAsParent = false;
-
-		try {
-			$serviceEntityRepository = $this->reflector->reflectClass('Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository');
-			if ($serviceEntityRepository->getParentClass() !== null) {
-				/** @var class-string $lazyServiceEntityRepositoryName */
-				$lazyServiceEntityRepositoryName = 'Doctrine\Bundle\DoctrineBundle\Repository\LazyServiceEntityRepository';
-				$hasLazyServiceEntityRepositoryAsParent = $serviceEntityRepository->getParentClass()->getName() === $lazyServiceEntityRepositoryName;
-			}
-		} catch (IdentifierNotFound $e) {
-			// pass
-		}
-
-		if ($hasLazyServiceEntityRepositoryAsParent) {
+		if ($this->hasLazyServiceEntityRepository()) {
 			$files[] = $stubsDir . '/LazyServiceEntityRepository.stub';
 		} else {
 			$files[] = $stubsDir . '/ServiceEntityRepository.stub';
@@ -73,6 +50,25 @@ public function getFiles(): array
 		return $files;
 	}
 
+	private function hasLazyServiceEntityRepository(): bool
+	{
+		if (!class_exists(InstalledVersions::class)) {
+			return false;
+		}
+
+		try {
+			$bundleVersion = InstalledVersions::getVersion('doctrine/doctrine-bundle');
+		} catch (OutOfBoundsException $e) {
+			return false;
+		}
+
+		if ($bundleVersion === null) {
+			return false;
+		}
+
+		return version_compare($bundleVersion, '2.8.1', '>=') && version_compare($bundleVersion, '3.0.0', '<');
+	}
+
 	private function isInstalledVersion(string $package, int $majorVersion): bool
 	{
 		if (!class_exists(InstalledVersions::class)) {

tests/Stubs/StubFilesExtensionLoaderTest.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Stubs;
+
+use PHPStan\Stubs\Doctrine\StubFilesExtensionLoader;
+use PHPStan\Testing\PHPStanTestCase;
+use function dirname;
+use function in_array;
+
+class StubFilesExtensionLoaderTest extends PHPStanTestCase
+{
+
+	public function testGetFilesDoesNotTriggerSourceLocator(): void
+	{
+		$loader = self::getContainer()->getByType(StubFilesExtensionLoader::class);
+		$files = $loader->getFiles();
+
+		$this->assertNotEmpty($files);
+
+		$stubsDir = dirname(dirname(__DIR__)) . '/stubs';
+		$hasService = in_array($stubsDir . '/ServiceEntityRepository.stub', $files, true);
+		$hasLazy = in_array($stubsDir . '/LazyServiceEntityRepository.stub', $files, true);
+		$this->assertTrue(
+			($hasService || $hasLazy) && !($hasService && $hasLazy),
+			'Exactly one ServiceEntityRepository stub variant must be selected',
+		);
+		foreach ($files as $file) {
+			$this->assertFileExists($file);
+		}
+	}
+
+	/** @return string[] */
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [__DIR__ . '/phpstan.neon'];
+	}
+
+}

tests/Stubs/ThrowingSourceLocator.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Stubs;
+
+use LogicException;
+use PHPStan\BetterReflection\Identifier\Identifier;
+use PHPStan\BetterReflection\Identifier\IdentifierType;
+use PHPStan\BetterReflection\Reflection\Reflection;
+use PHPStan\BetterReflection\Reflector\Reflector;
+use PHPStan\BetterReflection\SourceLocator\Type\SourceLocator;
+
+class ThrowingSourceLocator implements SourceLocator
+{
+
+	public function locateIdentifier(Reflector $reflector, Identifier $identifier): ?Reflection
+	{
+		throw new LogicException('StubFilesExtensionLoader::getFiles() must not trigger SourceLocator::locateIdentifier()');
+	}
+
+	/** @return list<Reflection> */
+	public function locateIdentifiersByType(Reflector $reflector, IdentifierType $identifierType): array
+	{
+		throw new LogicException('StubFilesExtensionLoader::getFiles() must not trigger SourceLocator::locateIdentifiersByType()');
+	}
+
+}

tests/Stubs/phpstan.neon

@@ -0,0 +1,8 @@
+services:
+	betterReflectionSourceLocator:
+		class: PHPStan\Stubs\Doctrine\ThrowingSourceLocator
+
+	-
+		class: PHPStan\Stubs\Doctrine\StubFilesExtensionLoader
+		tags:
+			- phpstan.stubFilesExtension