Move throw type test to dedicated test class

Author: janedbal

tests/PHPStan/Rules/Exceptions/DomDocumentCreateElementThrowTypeExtensionTest.php

@@ -0,0 +1,46 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Exceptions;
+
+use PHPStan\Rules\Rule;
+use PHPStan\ShouldNotHappenException;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<MissingCheckedExceptionInMethodThrowsRule>
+ */
+class DomDocumentCreateElementThrowTypeExtensionTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new MissingCheckedExceptionInMethodThrowsRule(
+			new MissingCheckedExceptionInThrowsCheck(new DefaultExceptionTypeResolver(
+				self::createReflectionProvider(),
+				[],
+				[ShouldNotHappenException::class],
+				[],
+				[],
+			)),
+		);
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13792.php'], [
+			[
+				'Method Bug13792\Foo::dynamicName() throws checked exception DOMException but it\'s missing from the PHPDoc @throws tag.',
+				20,
+			],
+			[
+				'Method Bug13792\Foo::invalidConstantName() throws checked exception DOMException but it\'s missing from the PHPDoc @throws tag.',
+				25,
+			],
+			[
+				'Method Bug13792\Foo::unions() throws checked exception DOMException but it\'s missing from the PHPDoc @throws tag.',
+				36,
+			],
+		]);
+	}
+
+}

tests/PHPStan/Rules/Exceptions/MissingCheckedExceptionInMethodThrowsRuleTest.php

@@ -67,10 +67,6 @@ public function testRule(): void
 				122,
 			];
 		}
-		$errors[] = [
-			'Method MissingExceptionMethodThrows\Foo::domCreateElementDoesThrow() throws checked exception DOMException but it\'s missing from the PHPDoc @throws tag.',
-			133,
-		];
 		$this->analyse([__DIR__ . '/data/missing-exception-method-throws.php'], $errors);
 	}
 

tests/PHPStan/Rules/Exceptions/data/bug-13792.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types = 1);
+
+namespace Bug13792;
+
+use DOMDocument;
+
+class Foo
+{
+
+	public function validConstantNames(DOMDocument $doc): void
+	{
+		$doc->createElement('div');
+		$doc->createElement('my-element');
+		$doc->createElement('ns:tag');
+		$doc->createElement('_private');
+	}
+
+	public function dynamicName(DOMDocument $doc, string $name): void
+	{
+		$doc->createElement($name); // error
+	}
+
+	public function invalidConstantName(DOMDocument $doc): void
+	{
+		$doc->createElement(''); // error
+	}
+
+	/**
+	 * @param 'div'|'span' $validUnion
+	 * @param 'div'|'' $mixedUnion
+	 */
+	public function unions(DOMDocument $doc, string $validUnion, string $mixedUnion): void
+	{
+		$doc->createElement($validUnion);
+		$doc->createElement($mixedUnion); // error
+	}
+
+}

tests/PHPStan/Rules/Exceptions/data/missing-exception-method-throws.php

@@ -122,15 +122,4 @@ public function dateTimeModifyDoesThrows(\DateTime $dt, \DateTimeImmutable $dti,
 		$dti->modify($m);
 	}
 
-	public function domCreateElementDoesNotThrow(\DOMDocument $doc): void
-	{
-		$doc->createElement('div');
-		$doc->createElement('my-element');
-	}
-
-	public function domCreateElementDoesThrow(\DOMDocument $doc, string $name): void
-	{
-		$doc->createElement($name);
-	}
-
 }