address review: test + warning

Author: skirpichev

Lib/test/test_array.py

@@ -118,6 +118,8 @@ def __index__(self):
 IEEE_754_DOUBLE_COMPLEX_LE = 24
 IEEE_754_DOUBLE_COMPLEX_BE = 25
 
+MACHINE_FORMAT_CODE_MAX = 25
+
 
 class ArrayReconstructorTest(unittest.TestCase):
 
@@ -143,7 +145,7 @@ def test_error(self):
         self.assertRaises(ValueError, array_reconstructor,
                           array.array, "b", UNKNOWN_FORMAT, b"")
         self.assertRaises(ValueError, array_reconstructor,
-                          array.array, "b", 26, b"")
+                          array.array, "b", MACHINE_FORMAT_CODE_MAX + 1, b"")
         self.assertRaises(ValueError, array_reconstructor,
                           array.array, "d", 16, b"a")
 

Modules/arraymodule.c

@@ -672,8 +672,8 @@ cf_setitem(arrayobject *ap, Py_ssize_t i, PyObject *v)
 
     CHECK_ARRAY_BOUNDS(ap, i);
 
-    f[0] = x.real;
-    f[1] = x.imag;
+    f[0] = (float)x.real;
+    f[1] = (float)x.imag;
     if (i >= 0) {
         memcpy(ap->ob_item + i*sizeof(f), &f, sizeof(f));
     }