gh-145966: Address review feedback: fix PEP-7 alignment, simplify NEWS, fix blank lines

Author: raminfp

Lib/test/test_csv.py

@@ -1280,7 +1280,6 @@ class mydialect(csv.Dialect):
                     self.assertRaises(ValueError, create_invalid, field_name, " ",
                                       skipinitialspace=True)
 
-
     def test_dialect_getattr_non_attribute_error_propagates(self):
         # gh-145966: non-AttributeError exceptions raised by __getattr__
         # during dialect attribute lookup must propagate, not be silenced.

Misc/NEWS.d/next/Library/2026-03-15-00-00-00.gh-issue-145966.tCI0uD4I.rst

@@ -1,4 +1,2 @@
-Fixed ``DIALECT_GETATTR`` macro in :mod:`csv` to only clear
-:exc:`AttributeError` exceptions. Previously, all exceptions (including
-:exc:`MemoryError` and :exc:`KeyboardInterrupt`) were silently suppressed
-when looking up dialect attributes.
+Non-:exc:`AttributeError` exceptions raised during dialect attribute lookup
+in :mod:`csv` are no longer silently suppressed.

Modules/_csv.c

@@ -497,18 +497,18 @@ dialect_new(PyTypeObject *type, PyObject *args, PyObject *kwargs)
     Py_XINCREF(skipinitialspace);
     Py_XINCREF(strict);
     if (dialect != NULL) {
-#define DIALECT_GETATTR(v, n)                            \
-        do {                                             \
-            if (v == NULL) {                             \
-                v = PyObject_GetAttrString(dialect, n);  \
-                if (v == NULL) {                         \
-                    if (PyErr_ExceptionMatches(           \
-                            PyExc_AttributeError))       \
-                        PyErr_Clear();                   \
-                    else                                 \
-                        goto err;                        \
-                }                                        \
-            }                                            \
+#define DIALECT_GETATTR(v, n)                                   \
+        do {                                                    \
+            if (v == NULL) {                                    \
+                v = PyObject_GetAttrString(dialect, n);         \
+                if (v == NULL) {                                \
+                    if (PyErr_ExceptionMatches(                  \
+                            PyExc_AttributeError))              \
+                        PyErr_Clear();                          \
+                    else                                        \
+                        goto err;                               \
+                }                                               \
+            }                                                   \
         } while (0)
         DIALECT_GETATTR(delimiter, "delimiter");
         DIALECT_GETATTR(doublequote, "doublequote");