`__lazy_import__` throws a `SystemError` if `globals` is not any dict

[devdanzin]

Bug report

Bug description:

The interpreter will raise a SystemError when __lazy_import__ is called with a second positional argument:

>>> __lazy_import__('', 1)
Traceback (most recent call last):
  File "<python-input-82>", line 1, in <module>
    __lazy_import__('', 1)
    ~~~~~~~~~~~~~~~^^^^^^^
SystemError: Objects/dictobject.c:2499: bad argument to internal function

Found using fusil by @vstinner.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

• gh-145076: Check globals type in __lazy_import__() #145086
• gh-145076: Validate type inputs in __lazy_import__ #145088

[johnslavik]

This reproduces just as well without any positional arguments:

>>> __lazy_import__(name='foo', globals=1)
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    __lazy_import__(name='foo', globals=1)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
SystemError: Objects/dictobject.c:2499: bad argument to internal function

globals isn't validated to be a dict or frozendict before being passed to PyDict_GetItemRef in builtin___lazy_import___impl.

[vstinner]

I wrote #145086 to check globals type before calling PyDict_GetItemRef() on it.