Clean up unused files from `Misc/`

[StanFromIreland]

Feature or enhancement

Bug description:

See #145973 for Misc/vgrindefs.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

• gh-145976: Remove Misc/{Porting,vgrindefs} #145973
• gh-145976: Remove Misc/indent.pro #145992

[picnixz]

I think we can also remove the ident.pro thing but I wonder whether it's being used or not. It should be used by the indent program but I believe that now that we have PEP-7, there isn't much to say about it. I can share my CLion configuration if it helps people as it tries to match PEP-7 as much as possible, though we have an oddity when we put { after an if on the next line if we need wrapping which isn't handled by the CLion formatter.

If it's not handled by indent either I think we can remove it. If VSCode can use indent.pro we may keep it but otherwise, I'm in favor of removing it.

[StanFromIreland]

I was split because it seems like it may still be useful (unlike the vgrindefs), I’ll install the tool and if it rejects the config file, I’ll open a PR to remove it.

Also, as a CLion user, please do share:-)

[StanFromIreland]

It works, but it's far off what we want, for example I ran it on _heapq_heappushpop_impl:

static PyObject *
_heapq_heappushpop_impl (PyObject *module, PyObject *heap, PyObject *item)
/*[clinic end generated code: output=67231dc98ed5774f input=db05c81b1dd92c44]*/
{
  PyObject *returnitem;
  int cmp;

  if (PyList_GET_SIZE (heap) == 0)
    {
      return Py_NewRef (item);
    }

  PyObject *top = PyList_GET_ITEM (heap, 0);
  Py_INCREF (top);
  cmp = PyObject_RichCompareBool (top, item, Py_LT);
  Py_DECREF (top);
  if (cmp < 0)
    return NULL;
  if (cmp == 0)
    {
      return Py_NewRef (item);
    }

  if (PyList_GET_SIZE (heap) == 0)
    {
      PyErr_SetString (PyExc_IndexError, "index out of range");
      return NULL;
    }

  returnitem = PyList_GET_ITEM (heap, 0);
  PyListObject *list = _PyList_CAST (heap);
  FT_ATOMIC_STORE_PTR_RELAXED (list->ob_item[0], Py_NewRef (item));
  if (siftup (list, 0))
    {
      Py_DECREF (returnitem);
      return NULL;
    }
  return returnitem;
}

I agree we should remove it.

[picnixz]

I don't think we have more files to remove. Thanks! however, and I don't know if it can be annoying or breaking, but would it make sense to have folders in NEWS.d for each version? currently we have all files at the same level but it will definitely grow bigger and bigger. I don't know if it makes sense to restructure that (and backport those changes so that we have less friction in the What's New files though What's New files are rarely changed in backports as they only concern features).

cc @hugovk

[StanFromIreland]

That seems more like a discussion for https://github.com/python/blurb.

I agree there are no other files to remove.