Skip to content

gh-145058: Add input validation to _PyImport_LazyImportModuleLevelObject#145068

Merged
pablogsal merged 3 commits intopython:mainfrom
StanFromIreland:lazy-val
Feb 21, 2026
Merged

gh-145058: Add input validation to _PyImport_LazyImportModuleLevelObject#145068
pablogsal merged 3 commits intopython:mainfrom
StanFromIreland:lazy-val

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Feb 21, 2026 •
edited by bedevere-app Bot
Loading

This copies the checks from PyImport_ImportModuleLevelObject to _PyImport_LazyImportModuleLevelObject.

@bedevere-app bedevere-app Bot mentioned this pull request Feb 21, 2026
Closed
vstinner
vstinner reviewed Feb 21, 2026
View reviewed changes
Comment thread Python/import.c Outdated
Comment thread Python/import.c Outdated
Comment thread Lib/test/test_import/test_lazy_imports.py Outdated
StanFromIreland and others added 2 commits February 21, 2026 10:26
@StanFromIreland @vstinner
Apply suggestions from code review
ea28d2b 
Co-authored-by: Victor Stinner <vstinner@python.org>
@StanFromIreland @vstinner
Apply suggestion from @vstinner
5b01fb5 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Feb 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit e1bd0cd into python:main Feb 21, 2026
51 checks passed
@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented Feb 21, 2026

Thanks a lot @StanFromIreland! 🚀

@StanFromIreland StanFromIreland deleted the lazy-val branch February 21, 2026 12:58
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@StanFromIreland @brijkapadia
pythongh-145058: Add input validation to `_PyImport_LazyImportModuleL…
5fb3e72 
…evelObject` (python#145068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@pablogsal pablogsal pablogsal approved these changes

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

@DinoV DinoV Awaiting requested review from DinoV

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees

No one assigned

Labels

topic-lazy-imports

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @pablogsal @vstinner @Yhg1s