Work around SEGFAULT on legacy PHP < 5.4 due to unbuffered reads

Author: clue

src/Process.php

@@ -126,6 +126,13 @@ public function start(LoopInterface $loop, $interval = 0.1)
         $this->stdout->on('close', $streamCloseHandler);
         $this->stderr = new Stream($this->pipes[2], $loop);
         $this->stderr->on('close', $streamCloseHandler);
+
+        // legacy PHP < 5.4 SEGFAULTs for unbuffered, non-blocking reads
+        // work around by enabling read buffer again
+        if (PHP_VERSION_ID < 50400) {
+            stream_set_read_buffer($this->pipes[1], 1);
+            stream_set_read_buffer($this->pipes[2], 1);
+        }
     }
 
     /**

tests/AbstractProcessTest.php

@@ -66,6 +66,46 @@ public function testGetTermSignalWhenRunning($process)
         $this->assertNull($process->getTermSignal());
     }
 
+    public function testReceivesProcessStdoutFromEcho()
+    {
+        $cmd = 'echo test';
+
+        $loop = $this->createLoop();
+        $process = new Process($cmd);
+        $process->start($loop);
+
+        $buffer = '';
+        $process->stdout->on('data', function ($data) use (&$buffer) {
+            $buffer .= $data;
+        });
+
+        $loop->run();
+
+        $this->assertEquals('test', rtrim($buffer));
+    }
+
+    public function testReceivesProcessStdoutFromDd()
+    {
+        if (!file_exists('/dev/zero')) {
+            $this->markTestSkipped('Unable to read from /dev/zero, Windows?');
+        }
+
+        $cmd = 'dd if=/dev/zero bs=12345 count=1234';
+
+        $loop = $this->createLoop();
+        $process = new Process($cmd);
+        $process->start($loop);
+
+        $bytes = 0;
+        $process->stdout->on('data', function ($data) use (&$bytes) {
+            $bytes += strlen($data);
+        });
+
+        $loop->run();
+
+        $this->assertEquals(12345 * 1234, $bytes);
+    }
+
     public function testProcessWithDefaultCwdAndEnv()
     {
         $cmd = $this->getPhpBinary() . ' -r ' . escapeshellarg('echo getcwd(), PHP_EOL, count($_SERVER), PHP_EOL;');