Skip to content

Commit 99c3d88

Browse files
committed
Replace isset() statements with null equality checks
1 parent 814a8af commit 99c3d88

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

Process.php

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public function start(LoopInterface $loop, $interval = 0.1)
129129
*/
130130
public function close()
131131
{
132-
if (!isset($this->process)) {
132+
if ($this->process === null) {
133133
return;
134134
}
135135

@@ -145,15 +145,15 @@ public function close()
145145
$exitCode = proc_close($this->process);
146146
$this->process = null;
147147

148-
if (!isset($this->exitCode) && -1 !== $exitCode) {
148+
if ($this->exitCode === null && $exitCode !== -1) {
149149
$this->exitCode = $exitCode;
150150
}
151151

152-
if (!isset($this->exitCode) && -1 !== $this->status['exitcode']) {
152+
if ($this->exitCode === null && $this->status['exitcode'] !== -1) {
153153
$this->exitCode = $this->status['exitcode'];
154154
}
155155

156-
if (!isset($this->exitCode) && isset($this->fallbackExitCode)) {
156+
if ($this->exitCode === null && $this->fallbackExitCode !== null) {
157157
$this->exitCode = $this->fallbackExitCode;
158158
$this->fallbackExitCode = null;
159159
}
@@ -167,7 +167,7 @@ public function close()
167167
*/
168168
public function terminate($signal = null)
169169
{
170-
if (isset($signal)) {
170+
if ($signal !== null) {
171171
return proc_terminate($this->process, $signal);
172172
}
173173

@@ -241,7 +241,7 @@ public function getPid()
241241
{
242242
$status = $this->getCachedStatus();
243243

244-
return isset($status) ? $status['pid'] : null;
244+
return $status !== null ? $status['pid'] : null;
245245
}
246246

247247
/**
@@ -277,13 +277,13 @@ public function getTermSignal()
277277
*/
278278
public function isRunning()
279279
{
280-
if (!isset($this->process)) {
280+
if ($this->process === null) {
281281
return false;
282282
}
283283

284284
$status = $this->getFreshStatus();
285285

286-
return isset($status) ? $status['running'] : false;
286+
return $status !== null ? $status['running'] : false;
287287
}
288288

289289
/**
@@ -295,7 +295,7 @@ public function isStopped()
295295
{
296296
$status = $this->getFreshStatus();
297297

298-
return isset($status) ? $status['stopped'] : false;
298+
return $status !== null ? $status['stopped'] : false;
299299
}
300300

301301
/**
@@ -307,7 +307,7 @@ public function isTerminated()
307307
{
308308
$status = $this->getFreshStatus();
309309

310-
return isset($status) ? $status['signaled'] : false;
310+
return $status !== null ? $status['signaled'] : false;
311311
}
312312

313313
/**
@@ -335,7 +335,7 @@ public final static function isSigchildEnabled()
335335
*/
336336
private function pollExitCodePipe()
337337
{
338-
if (!isset($this->pipes[3])) {
338+
if ( ! isset($this->pipes[3])) {
339339
return;
340340
}
341341

@@ -362,7 +362,7 @@ private function pollExitCodePipe()
362362
*/
363363
private function closeExitCodePipe()
364364
{
365-
if (!isset($this->pipes[3])) {
365+
if ( ! isset($this->pipes[3])) {
366366
return;
367367
}
368368

@@ -377,7 +377,7 @@ private function closeExitCodePipe()
377377
*/
378378
private function getCachedStatus()
379379
{
380-
if (!isset($this->status)) {
380+
if ($this->status === null) {
381381
$this->updateStatus();
382382
}
383383

@@ -405,7 +405,7 @@ private function getFreshStatus()
405405
*/
406406
private function updateStatus()
407407
{
408-
if (!isset($this->process)) {
408+
if ($this->process === null) {
409409
return;
410410
}
411411

0 commit comments

Comments
 (0)