False positive "Map comment with trailing content" on objects with objects as keys

[wsulais]

Describe the bug

Inline object keys are accept as a part of the YAML spec. Yet objects that contain more than one of them cause LSP errors.d

The following yaml is accepted

foo:
  { bar: 1 }: 1

But the following examples do cause the "Map comment with trailing content" error to always happens on the last line

foo:
  { bar: 1 }: 1
  { bar: 2 }: 1

foo:
  { bar: 1 }: 1
  { bar: 2 }: 1
  { bar: 3 }: 1

Environment

• Windows
• Mac
• Linux
• other (please specify)

Can reproduce with 1.19.2 and 1.21, i'm using nixpkgs built yaml-language-server.

[datho7561]

I'm pretty sure that's invalid YAML. None of the YAML parsers I've tried (eemeli/yaml and pyyaml) accept that as YAML. Where in the spec does it say objects can be used as keys?

[wsulais]

It is valid in YAML 1.2 (See examples 8.17–8.19). The parser i'm using, serde_saphyr calls it composite keys.

My examples are equivalent to this explicit YAML

foo:
  ? { bar: 1 }
  : 1
  ? { bar: 2 }
  : 1

and even further

foo:
  ? ? bar
    : 1
  : 1
  ? ? bar
    : 2
  : 1

By default, most python based YAML parsers won't accept this YAML as python dicts are mutable, and thus not hashable (and cannot be map keys). I can confirm my yaml is parsable by ruamel.yaml

[datho7561]

Okay, thanks. I think it might be related to eemeli/yaml#646, but I'm not certain.