Skip to content

Commit 3813003

Browse files
committed
Add ipv6 port binding
1 parent ceb894a commit 3813003

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

rocketpool-cli/service/config/settings-native-smartnode.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func NewNativeSmartnodeConfigPage(home *settingsNativeHome) *NativeSmartnodeConf
2323
configPage.page = newPage(
2424
home.homePage,
2525
"settings-native-smartnode",
26-
"Smartnode and TX Fees",
26+
"Smart Node and TX Fees",
2727
"Select this to configure the settings for the Smart Node itself, including the defaults and limits on transaction fees.",
2828
configPage.layout.grid,
2929
)
@@ -43,7 +43,8 @@ func (configPage *NativeSmartnodeConfigPage) createContent() {
4343
layout.setupEscapeReturnHomeHandler(configPage.home.md, configPage.home.homePage)
4444

4545
// Set up the form items
46-
formItems := createParameterizedFormItems(masterConfig.Smartnode.GetParameters(), layout.descriptionBox)
46+
params := append(masterConfig.Smartnode.GetParameters(), &masterConfig.EnableIPv6, &masterConfig.Alertmanager.ShowAlertsOnCLI)
47+
formItems := createParameterizedFormItems(params, layout.descriptionBox)
4748
for _, formItem := range formItems {
4849
if formItem.parameter.ID == config.ProjectNameID {
4950
// Ignore the project name ID since it doesn't apply to native mode

rocketpool-cli/service/config/settings-smartnode.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func NewSmartnodeConfigPage(home *settingsHome) *SmartnodeConfigPage {
2424
configPage.page = newPage(
2525
home.homePage,
2626
"settings-smartnode",
27-
"Smartnode and TX Fees",
27+
"Smart Node and TX Fees",
2828
"Select this to configure the settings for the Smart Node itself, including the defaults and limits on transaction fees.",
2929
configPage.layout.grid,
3030
)
@@ -67,7 +67,8 @@ func (configPage *SmartnodeConfigPage) createContent() {
6767
})
6868

6969
// Set up the form items
70-
formItems := createParameterizedFormItems(masterConfig.Smartnode.GetParameters(), layout.descriptionBox)
70+
params := append(masterConfig.Smartnode.GetParameters(), &masterConfig.EnableIPv6, &masterConfig.Alertmanager.ShowAlertsOnCLI)
71+
formItems := createParameterizedFormItems(params, layout.descriptionBox)
7172
for _, formItem := range formItems {
7273
layout.form.AddFormItem(formItem.item)
7374
layout.parameters[formItem.item] = formItem

rocketpool/node/check-port-connectivity.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ var publicIPResolvers = []struct {
2525
addr string // host:port (IP literal)
2626
hostname string // special hostname that returns the caller's public IP
2727
}{
28-
{"208.67.222.222:53", "myip.opendns.com"}, // OpenDNS primary (IPv4)
29-
{"208.67.220.220:53", "myip.opendns.com"}, // OpenDNS secondary (IPv4)
30-
{"216.239.32.10:53", "o-o.myaddr.l.google.com"}, // Google ns1 (IPv4)
31-
{"[2620:119:35::35]:53", "myip.opendns.com"}, // OpenDNS primary (IPv6)
32-
{"[2620:119:53::53]:53", "myip.opendns.com"}, // OpenDNS secondary (IPv6)
28+
{"208.67.222.222:53", "myip.opendns.com"}, // OpenDNS primary (IPv4)
29+
{"208.67.220.220:53", "myip.opendns.com"}, // OpenDNS secondary (IPv4)
30+
{"216.239.32.10:53", "o-o.myaddr.l.google.com"}, // Google ns1 (IPv4)
31+
{"[2620:119:35::35]:53", "myip.opendns.com"}, // OpenDNS primary (IPv6)
32+
{"[2620:119:53::53]:53", "myip.opendns.com"}, // OpenDNS secondary (IPv6)
3333
{"[2001:4860:4860::8888]:53", "o-o.myaddr.l.google.com"}, // Google ns1 (IPv6)
3434
}
3535

shared/services/rocketpool/assets/install/templates/eth2.tmpl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,20 @@ services:
3131
ports:
3232
- "{{$p2p}}:{{$p2p}}/udp"
3333
- "{{$p2p}}:{{$p2p}}/tcp"
34+
{{- if .IsIPv6Enabled}}
35+
- "[::]:{{$p2p}}:{{$p2p}}/udp"
36+
- "[::]:{{$p2p}}:{{$p2p}}/tcp"
37+
{{- end}}
3438
{{- if eq .ConsensusClient.String "lighthouse"}}
3539
- "{{.Lighthouse.P2pQuicPort}}:{{.Lighthouse.P2pQuicPort}}/udp"
40+
{{- if .IsIPv6Enabled}}
41+
- "[::]:{{.Lighthouse.P2pQuicPort}}:{{.Lighthouse.P2pQuicPort}}/udp"
42+
{{- end}}
3643
{{- else if eq .ConsensusClient.String "prysm"}}
3744
- "{{.Prysm.P2pQuicPort}}:{{.Prysm.P2pQuicPort}}/udp"
45+
{{- if .IsIPv6Enabled}}
46+
- "[::]:{{.Prysm.P2pQuicPort}}:{{.Prysm.P2pQuicPort}}/udp"
47+
{{- end}}
3848
{{- end}}
3949
{{- if and (eq .ConsensusClient.String "teku") .IsIPv6Enabled}}
4050
- "{{.Teku.P2pIpv6Port}}:{{.Teku.P2pIpv6Port}}/udp"

0 commit comments

Comments
 (0)