Merge pull request #8 from simplesamlphp/feature/replace-superlinter #116
tvdijenphp.yml
on: push
Matrix: PHP-Linter
Linter
/
ecmascript-linter
Linter
/
json-linter
Linter
/
style-linter
Linter
/
yaml-linter
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Cleanup artifacts
6s
Annotations
13 errors and 2 warnings
|
Quality control
Process completed with exit code 2.
|
|
MissingOverrideAttribute:
tests/src/Controller/CDCTest.php#L32
tests/src/Controller/CDCTest.php:32:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\cdc\Controller\CDCTest::setupbeforeclass should have the "Override" attribute (see https://psalm.dev/358)
|
|
UnusedClass:
tests/src/Controller/CDCTest.php#L20
tests/src/Controller/CDCTest.php:20:13: UnusedClass: Class SimpleSAML\Test\Module\cdc\Controller\CDCTest is never used (see https://psalm.dev/075)
|
|
UnusedParam:
src/Server.php#L244
src/Server.php:244:39: UnusedParam: Param request is never referenced in this method (see https://psalm.dev/135)
|
|
UnusedParam:
src/Server.php#L223
src/Server.php:223:41: UnusedParam: Param request is never referenced in this method (see https://psalm.dev/135)
|
|
ClassMustBeFinal:
src/Server.php#L20
src/Server.php:20:7: ClassMustBeFinal: Class SimpleSAML\Module\cdc\Server is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
DocblockTypeContradiction:
src/Controller/CDC.php#L91
src/Controller/CDC.php:91:13: DocblockTypeContradiction: Cannot resolve types for $state - docblock-defined type array<array-key, mixed> does not contain null (see https://psalm.dev/155)
|
|
ArgumentTypeCoercion:
src/Controller/CDC.php#L79
src/Controller/CDC.php:79:30: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Module\cdc\Client::__construct expects string, but parent type scalar provided (see https://psalm.dev/193)
|
|
ClassMustBeFinal:
src/Controller/CDC.php#L23
src/Controller/CDC.php:23:7: ClassMustBeFinal: Class SimpleSAML\Module\cdc\Controller\CDC is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
UnusedProperty:
src/Client.php#L20
src/Client.php:20:20: UnusedProperty: Cannot find any references to private property SimpleSAML\Module\cdc\Client::$domain (see https://psalm.dev/150)
|
|
ClassMustBeFinal:
src/Client.php#L13
src/Client.php:13:7: ClassMustBeFinal: Class SimpleSAML\Module\cdc\Client is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
MissingOverrideAttribute:
src/Auth/Process/CDC.php#L59
src/Auth/Process/CDC.php:59:5: MissingOverrideAttribute: Method SimpleSAML\module\cdc\Auth\Process\CDC::process should have the "Override" attribute (see https://psalm.dev/358)
|
|
ClassMustBeFinal:
src/Auth/Process/CDC.php#L18
src/Auth/Process/CDC.php:18:7: ClassMustBeFinal: Class SimpleSAML\module\cdc\Auth\Process\CDC is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
UnusedClass:
src/Controller/CDC.php#L23
src/Controller/CDC.php:23:7: UnusedClass: Class SimpleSAML\Module\cdc\Controller\CDC is never used (see https://psalm.dev/075)
|
|
UnusedClass:
src/Auth/Process/CDC.php#L18
src/Auth/Process/CDC.php:18:7: UnusedClass: Class SimpleSAML\module\cdc\Auth\Process\CDC is never used (see https://psalm.dev/075)
|