Skip to content

Commit ded07df

Browse files
committed
Un-nest CanonicalizableElementTrait from Signed/SignableElementTrait
1 parent d0d8313 commit ded07df

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

src/XML/SignableElementTrait.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@
3939
*/
4040
trait SignableElementTrait
4141
{
42-
use CanonicalizableElementTrait;
43-
44-
4542
/** @var \SimpleSAML\XMLSecurity\XML\ds\Signature|null */
4643
protected ?Signature $signature = null;
4744

src/XML/SignedElementTrait.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@
4242
*/
4343
trait SignedElementTrait
4444
{
45-
use CanonicalizableElementTrait;
46-
47-
4845
/**
4946
* The signature of this element.
5047
*

tests/XML/CustomSignable.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
use SimpleSAML\XMLSchema\Exception\TooManyElementsException;
1212
use SimpleSAML\XMLSchema\Type\IDValue;
1313
use SimpleSAML\XMLSecurity\Backend\EncryptionBackend;
14+
use SimpleSAML\XMLSecurity\XML\CanonicalizableElementInterface;
15+
use SimpleSAML\XMLSecurity\XML\CanonicalizableElementTrait;
1416
use SimpleSAML\XMLSecurity\XML\ds\Signature;
1517
use SimpleSAML\XMLSecurity\XML\EncryptableElementInterface;
1618
use SimpleSAML\XMLSecurity\XML\EncryptableElementTrait;
@@ -25,10 +27,12 @@
2527
* @package simplesamlphp/xml-security
2628
*/
2729
class CustomSignable extends AbstractElement implements
30+
CanonicalizableElementInterface,
2831
SignableElementInterface,
2932
SignedElementInterface,
3033
EncryptableElementInterface
3134
{
35+
use CanonicalizableElementTrait;
3236
use SignableElementTrait;
3337
use SignedElementTrait;
3438
use EncryptableElementTrait;

0 commit comments

Comments
 (0)