Skip to content

Commit db9c65e

Browse files
committed
fix(teams): remove smba.trafficmanager.net from Microsoft content allowlist
The subdomain check for smba.trafficmanager.net was unnecessary — Azure Traffic Manager does not support nested subdomains of existing profiles, but the pattern still raised a valid audit concern. Teams bot-framework attachment URLs from this host fall through to the generic fetchWithDNSPinning branch, which provides the same protection without the ambiguity.
1 parent e2ed88b commit db9c65e

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

apps/sim/lib/core/security/input-validation.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1219,7 +1219,6 @@ const MICROSOFT_CONTENT_SUFFIXES = [
12191219
'1drv.ms',
12201220
'1drv.com',
12211221
'microsoftpersonalcontent.com',
1222-
'smba.trafficmanager.net',
12231222
] as const
12241223

12251224
/**
@@ -1229,8 +1228,7 @@ const MICROSOFT_CONTENT_SUFFIXES = [
12291228
*
12301229
* Covers SharePoint Online (commercial, GCC/GCC High/DoD, Germany, China),
12311230
* OneDrive business and consumer, OneDrive short-link and CDN domains,
1232-
* Microsoft personal content CDN, and the Azure Traffic Manager endpoint
1233-
* used for Teams inline image attachments.
1231+
* and Microsoft personal content CDN.
12341232
*
12351233
* @see https://learn.microsoft.com/en-us/sharepoint/required-urls-and-ports
12361234
* @see https://learn.microsoft.com/en-us/microsoft-365/enterprise/microsoft-365-u-s-government-gcc-high-endpoints

0 commit comments

Comments
 (0)