custom struct tags are not emmited

[bluebrown]

Version

1.25.0

What happened?

I am trying to set a custom struct tag but its not generated with the model.

Relevant log output

// Code generated by sqlc. DO NOT EDIT.
// versions:
//   sqlc v1.25.0

package store

import (
	"database/sql"
)

type Test struct {
	Nullstring sql.NullString
}

Database schema

create table test (
  nullstring text
)

SQL queries

-- name: read :one
select * from test where nullstring = ?;

Configuration

version: "2"
sql:
- engine: sqlite
  queries: ./query.sql
  schema: ./schema.sql
  gen:
    go:
      package: store
      out: ./store/
      overrides:
      - db_type: text
        nullable: true
        go_struct_tag: a:"b"

Playground URL

No response

What operating system are you using?

Linux

What database engines are you using?

SQLite

What type of code are you generating?

Go

[rishi-kulkarni]

This might just be a YAML ambiguity issue - does it work if you change the tagline to:

go_struct_tag: 'a:"b"'

[emanuelturis]

Seems that it's only working if a column is set, so if "globally scoped" to a type it doesn't write it to the file, but if a column like "countdowns.date" is set it works.

[RickMortynson]

The issue seems to still persist. Any workarounds?

[andrewmbenton]

The issue seems to still persist. Any workarounds?

The issue is correctly described above. The go_struct_tag parameter appears to only be considered for column overrides, not db_type overrides. There may be some fundamental reason for this but I will keep investigating.

[emanuelturis]

The issue seems to still persist. Any workarounds?

The issue is correctly described above. The go_struct_tag parameter appears to only be considered for column overrides, not db_type overrides. There may be some fundamental reason for this but I will keep investigating.

I've provided a pull request a while ago that solves this. #3287

Kind of a workaround but might help you figure out the source of the problem.

[andrewmbenton]

Sorry I missed your PR. You found the source of the problem. All I did in my PR (#4055) was refactor a little bit and add tests.

[emanuelturis]

Sorry I missed your PR. You found the source of the problem. All I did in my PR (#4055) was refactor a little bit and add tests.

No worries! Glad it got solved!