Skip to content

Commit 02c0ff1

Browse files
committed
Address feedback
- missing `type: external_auth_config_ref` for backend auth config - note about requiring `jwksAllowPrivateIP` for cluster-internal addresses only - note about redis replicas and failover
1 parent ebd8872 commit 02c0ff1

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

docs/toolhive/guides-k8s/redis-session-storage.mdx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,9 @@ spec:
163163
```
164164
165165
The next section deploys a three-node Sentinel cluster that monitors the Redis
166-
master and handles automatic failover:
166+
master. With a single master and no replicas, Sentinel provides master discovery
167+
for ToolHive but cannot perform automatic failover. To enable failover, add
168+
Redis replicas to the StatefulSet and configure replication.
167169
168170
```yaml title="redis-sentinel.yaml — Sentinel cluster (append to same file)"
169171
# --- Sentinel configuration

docs/toolhive/guides-vmcp/authentication.mdx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ spec:
189189
source: inline
190190
backends:
191191
backend-github:
192+
type: external_auth_config_ref
192193
externalAuthConfigRef:
193194
name: inject-github
194195
```
@@ -257,9 +258,11 @@ spec:
257258
source: inline
258259
backends:
259260
backend-github:
261+
type: external_auth_config_ref
260262
externalAuthConfigRef:
261263
name: inject-github
262264
backend-okta-app:
265+
type: external_auth_config_ref
263266
externalAuthConfigRef:
264267
name: exchange-okta
265268
```
@@ -424,9 +427,10 @@ at `authed_user.access_token`). Add a `tokenResponseMapping` block to the
424427
### Incoming auth with the embedded auth server
425428

426429
When using the embedded auth server, configure `incomingAuth` to validate the
427-
JWTs it issues. The `issuer` must match `authServerConfig.issuer`, and
428-
`jwksAllowPrivateIP` must be `true` because the vMCP validates tokens from its
429-
own in-process auth server via loopback:
430+
JWTs it issues. The `issuer` must match `authServerConfig.issuer`. If the issuer
431+
URL resolves to a private or cluster-internal IP address (typical in
432+
Kubernetes), set `jwksAllowPrivateIP` to `true` so the OIDC middleware can fetch
433+
the JWKS from the embedded auth server's discovery endpoint:
430434

431435
```yaml title="VirtualMCPServer resource"
432436
spec:
@@ -576,6 +580,7 @@ spec:
576580
source: inline
577581
backends:
578582
backend-github:
583+
type: external_auth_config_ref
579584
externalAuthConfigRef:
580585
name: inject-github
581586
```

0 commit comments

Comments
 (0)