Skip to content

Refactor: replace copyView in ndarray/array/lib/copy_view.js with ndarray/copy #10935

@Aniket-SS

Description

@Aniket-SS

Description

In ndarray/array/lib/copy_view.js, the copyView function manually creates an output buffer, constructs a plain ndarray-like
object, and uses ndarray/base/assign to copy data.

The function contains the following TODO comment:

function copyView( arr, dtype ) { // TODO: consider replacing with `@stdlib/ndarray[/base]/copy` once created

Now that ndarray/copy exists, the manual logic can be replaced by importing ndarray/copy, removing the following unnecessary imports:

  • @stdlib/ndarray/base/assert/is-equal-data-type
  • @stdlib/buffer/alloc-unsafe
  • @stdlib/ndarray/base/buffer-ctors
  • @stdlib/ndarray/order
  • @stdlib/ndarray/base/numel
  • @stdlib/ndarray/base/shape2strides
  • @stdlib/ndarray/base/assign
  • @stdlib/array/base/zeros

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions