test: add regresison tests for requesting non-major version and fetching typings from catalog (#2257)

Part of #2253.

These tests show that when a non-major version is requested, we first
try to fetch typings from the catalog for its corresponding major
version.

Author: krzema12

action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/typing/TypesProvidingTest.kt

@@ -195,6 +195,12 @@ class TypesProvidingTest :
                   stored-in-typing-catalog-for-older-version:
                     type: string
                 """.trimIndent()
+            val storedInTypingCatalogForMajorVersion =
+                """
+                inputs:
+                  stored-in-typing-catalog-for-major-version:
+                    type: string
+                """.trimIndent()
 
             test("only hosted by the action (.yml)") {
                 // Given
@@ -636,6 +642,49 @@ class TypesProvidingTest :
                     )
             }
 
+            test("only stored in typing catalog for same major version using non-major version") {
+                // Given
+                val mockClient =
+                    HttpClient(
+                        MockEngine { request ->
+                            if (request.url.toString() ==
+                                "https://raw.githubusercontent.com/typesafegithub/github-actions-typing-catalog/" +
+                                "main/typings/some-owner/some-name/metadata.yml"
+                            ) {
+                                respond(metadata)
+                            } else if (request.url.toString() ==
+                                "https://raw.githubusercontent.com/typesafegithub/github-actions-typing-catalog/" +
+                                "main/typings/some-owner/some-name/v4/action-types.yml"
+                            ) {
+                                respond(storedInTypingCatalogForMajorVersion)
+                            } else if (request.url.toString() ==
+                                "https://raw.githubusercontent.com/typesafegithub/github-actions-typing-catalog/" +
+                                "main/typings/some-owner/some-name/v3/action-types.yml"
+                            ) {
+                                respond(storedInTypingCatalogForOlderVersion)
+                            } else {
+                                respond("Not found", status = HttpStatusCode.NotFound)
+                            }
+                        },
+                    )
+                val actionCoord = ActionCoords("Some-owner", "Some-name", "v4.1.2")
+
+                // When
+                val types =
+                    actionCoord.provideTypes(
+                        metadataRevision = CommitHash("some-hash"),
+                        httpClient = mockClient,
+                    )
+
+                // Then
+                types shouldBe
+                    ActionTypings(
+                        inputTypings = mapOf("stored-in-typing-catalog-for-major-version" to StringTyping),
+                        source = TypingActualSource.TYPING_CATALOG,
+                        fromFallbackVersion = false,
+                    )
+            }
+
             test("only stored in typing catalog for older version using commit pinning") {
                 // Given
                 val mockClient =
@@ -792,6 +841,49 @@ class TypesProvidingTest :
                     )
             }
 
+            test("only stored in typing catalog for same major version of subaction using non-major version") {
+                // Given
+                val mockClient =
+                    HttpClient(
+                        MockEngine { request ->
+                            if (request.url.toString() ==
+                                "https://raw.githubusercontent.com/typesafegithub/github-actions-typing-catalog/" +
+                                "main/typings/some-owner/some-name/metadata.yml"
+                            ) {
+                                respond(metadata)
+                            } else if (request.url.toString() ==
+                                "https://raw.githubusercontent.com/typesafegithub/github-actions-typing-catalog/" +
+                                "main/typings/some-owner/some-name/v4/some-sub/action-types.yml"
+                            ) {
+                                respond(storedInTypingCatalogForMajorVersion)
+                            } else if (request.url.toString() ==
+                                "https://raw.githubusercontent.com/typesafegithub/github-actions-typing-catalog/" +
+                                "main/typings/some-owner/some-name/v3/some-sub/action-types.yml"
+                            ) {
+                                respond(storedInTypingCatalogForOlderVersion)
+                            } else {
+                                respond("Not found", status = HttpStatusCode.NotFound)
+                            }
+                        },
+                    )
+                val actionCoord = ActionCoords("some-owner", "some-name", "v4.1.2", FULL, path = "some-sub")
+
+                // When
+                val types =
+                    actionCoord.provideTypes(
+                        metadataRevision = CommitHash("some-hash"),
+                        httpClient = mockClient,
+                    )
+
+                // Then
+                types shouldBe
+                    ActionTypings(
+                        inputTypings = mapOf("stored-in-typing-catalog-for-major-version" to StringTyping),
+                        source = TypingActualSource.TYPING_CATALOG,
+                        fromFallbackVersion = false,
+                    )
+            }
+
             test("only stored in typing catalog for older version of subaction using commit pinning") {
                 // Given
                 val mockClient =