fix(test): resolve ws CJS named export error with cloudflare preset

closes #831

When Nuxt's cloudflare preset is active, vitest passes `--conditions browser`
to worker processes. This caused `ws` to resolve to its browser stub
(`ws/browser.js`) instead of the ESM wrapper (`ws/wrapper.mjs`), because
the test package's `node` export condition loaded `index-node.js` which
imports `@vitest/browser/index.js` → `ws`.

Fix by adding a `browser` export condition before `node` in the test
package's main export. When `--conditions browser` is active, `browser`
matches first and resolves to `dist/index.js` (which doesn't pull in
`@vitest/browser`), avoiding the ws resolution issue.

Also fix ecosystem-ci `patch-project.ts` to apply pnpm overrides for
projects that already use Vite+ (previously skipped by `vp migrate`),
and add the reproduction repo as an e2e test case.

Author: fengmk2

.github/workflows/e2e-test.yml

@@ -246,6 +246,10 @@ jobs:
               vp run type-check:tsgo
               vp run build
               vp run test navigation-utils.test.ts real-browser-flicker.test.tsx workflow-parallel-limit.test.tsx
+          - name: viteplus-ws-repro
+            node-version: 24
+            command: |
+              vp test run
         exclude:
           # frm-stack uses Docker (testcontainers) which doesn't work the same way on Windows
           - os: windows-latest

ecosystem-ci/patch-project.ts

@@ -1,4 +1,5 @@
 import { execSync } from 'node:child_process';
+import { existsSync } from 'node:fs';
 import { readFile, writeFile } from 'node:fs/promises';
 import { join } from 'node:path';
 
@@ -21,6 +22,14 @@ const cwd = directory ? join(repoRoot, directory) : repoRoot;
 // run vp migrate
 const cli = process.env.VITE_PLUS_CLI_BIN ?? 'vp';
 
+const overridePackages: Record<string, string> = {
+  vite: `file:${tgzDir}/voidzero-dev-vite-plus-core-0.0.0.tgz`,
+  vitest: `file:${tgzDir}/voidzero-dev-vite-plus-test-0.0.0.tgz`,
+  '@voidzero-dev/vite-plus-core': `file:${tgzDir}/voidzero-dev-vite-plus-core-0.0.0.tgz`,
+  '@voidzero-dev/vite-plus-test': `file:${tgzDir}/voidzero-dev-vite-plus-test-0.0.0.tgz`,
+};
+const vitePlusVersion = `file:${tgzDir}/vite-plus-0.0.0.tgz`;
+
 if (project === 'rollipop') {
   const oxfmtrc = await readFile(join(repoRoot, '.oxfmtrc.json'), 'utf-8');
   await writeFile(
@@ -35,12 +44,47 @@ execSync(`${cli} migrate --no-agent --no-interactive`, {
   stdio: 'inherit',
   env: {
     ...process.env,
-    VITE_PLUS_OVERRIDE_PACKAGES: JSON.stringify({
-      vite: `file:${tgzDir}/voidzero-dev-vite-plus-core-0.0.0.tgz`,
-      vitest: `file:${tgzDir}/voidzero-dev-vite-plus-test-0.0.0.tgz`,
-      '@voidzero-dev/vite-plus-core': `file:${tgzDir}/voidzero-dev-vite-plus-core-0.0.0.tgz`,
-      '@voidzero-dev/vite-plus-test': `file:${tgzDir}/voidzero-dev-vite-plus-test-0.0.0.tgz`,
-    }),
-    VITE_PLUS_VERSION: `file:${tgzDir}/vite-plus-0.0.0.tgz`,
+    VITE_PLUS_OVERRIDE_PACKAGES: JSON.stringify(overridePackages),
+    VITE_PLUS_VERSION: vitePlusVersion,
   },
 });
+
+// vp migrate skips override injection for projects already using Vite+.
+// Apply overrides so e2e tests use the locally built packages.
+const workspaceYamlPath = join(cwd, 'pnpm-workspace.yaml');
+if (existsSync(workspaceYamlPath)) {
+  // pnpm catalogs don't support the file: protocol, so we replace
+  // workspace-level overrides (which point to "catalog:") with direct
+  // file: tgz paths, and add overrides for transitive deps.
+  let yaml = await readFile(workspaceYamlPath, 'utf-8');
+  // Replace existing "catalog:" overrides with direct tgz paths
+  yaml = yaml.replace(/^(\s+)(vite|vitest):\s*"catalog:"$/gm, (_, indent, pkg) => {
+    const tgzPath = pkg === 'vite' ? overridePackages.vite : overridePackages.vitest;
+    return `${indent}${pkg}: ${tgzPath}`;
+  });
+  // Add overrides for transitive deps and vite-plus itself
+  const additionalOverrides = {
+    '@voidzero-dev/vite-plus-core': overridePackages['@voidzero-dev/vite-plus-core'],
+    '@voidzero-dev/vite-plus-test': overridePackages['@voidzero-dev/vite-plus-test'],
+    'vite-plus': vitePlusVersion,
+  };
+  const overridesLines = Object.entries(additionalOverrides)
+    .map(([name, version]) => {
+      const key = /[/@]/.test(name) ? `"${name}"` : name;
+      return `  ${key}: ${version}`;
+    })
+    .join('\n');
+  yaml = yaml.replace(/^overrides:\n/m, `overrides:\n${overridesLines}\n`);
+  await writeFile(workspaceYamlPath, yaml, 'utf-8');
+} else {
+  // No workspace config — apply pnpm overrides in package.json directly
+  const pkgPath = join(cwd, 'package.json');
+  const pkg = JSON.parse(await readFile(pkgPath, 'utf-8'));
+  pkg.pnpm = pkg.pnpm || {};
+  pkg.pnpm.overrides = pkg.pnpm.overrides || {};
+  const allOverrides = { ...overridePackages, 'vite-plus': vitePlusVersion };
+  for (const [name, version] of Object.entries(allOverrides)) {
+    pkg.pnpm.overrides[name] = version;
+  }
+  await writeFile(pkgPath, JSON.stringify(pkg, null, 2) + '\n', 'utf-8');
+}

ecosystem-ci/repo.json

@@ -54,5 +54,10 @@
     "repository": "https://github.com/fengmk2/vite-vue-vercel.git",
     "branch": "main",
     "hash": "f2bf9fc40880c6a80f5d89bff70641c2eeaf77ef"
+  },
+  "viteplus-ws-repro": {
+    "repository": "https://github.com/Charles5277/viteplus-ws-repro.git",
+    "branch": "main",
+    "hash": "451925ad7c07750a23de1d6ed454825d0eb14092"
   }
 }

packages/test/build.ts

@@ -302,9 +302,18 @@ async function mergePackageJson(pluginExports: Array<{ exportPath: string; shimF
     // browser-provider exports. Browser code uses index.js which is safe.
     // This separation prevents Node.js-only code (like __vite__injectQuery) from being
     // loaded in the browser, which would cause "Identifier already declared" errors.
+    //
+    // IMPORTANT: The 'browser' condition must come BEFORE 'node' because vitest passes
+    // custom --conditions (like 'browser') to worker processes when frameworks like Nuxt
+    // set edge/cloudflare presets. Without the 'browser' condition here, Node.js would
+    // match 'node' first, loading index-node.js which imports @vitest/browser/index.js,
+    // which imports 'ws'. With --conditions browser active, 'ws' resolves to its browser
+    // stub (ws/browser.js) that doesn't export WebSocketServer, causing a SyntaxError.
+    // See: https://github.com/voidzero-dev/vite-plus/issues/831
     if (destPkg.exports['.'] && destPkg.exports['.'].import) {
       destPkg.exports['.'].import = {
         types: destPkg.exports['.'].import.types,
+        browser: destPkg.exports['.'].import.default,
         node: './dist/index-node.js',
         default: destPkg.exports['.'].import.default,
       };

packages/test/package.json

@@ -26,6 +26,7 @@
     ".": {
       "import": {
         "types": "./dist/index.d.ts",
+        "browser": "./dist/index.js",
         "node": "./dist/index-node.js",
         "default": "./dist/index.js"
       },